From owner-freebsd-wireless@FreeBSD.ORG Wed Oct 16 04:54:33 2013 Return-Path: Delivered-To: freebsd-wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 1D743C5 for ; Wed, 16 Oct 2013 04:54:33 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qa0-x231.google.com (mail-qa0-x231.google.com [IPv6:2607:f8b0:400d:c00::231]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CA8A52FBB for ; Wed, 16 Oct 2013 04:54:32 +0000 (UTC) Received: by mail-qa0-f49.google.com with SMTP id i13so300137qae.8 for ; Tue, 15 Oct 2013 21:54:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=JpkdHFSQ8XNg7aLeoy+Bh036a4EeS1iVY1aFpLJ1oek=; b=cQVu9CvKMa0a/xXkmIbjKIs0scnD/GdJy2SPpVQquvB5Y8GGTqAjTiPPvs2CypGiup UlLpmtK8VMVLBLmFc6pKyI+J032xwEtOswKomfM5rK2yCMBmpYQEIY+80As8Rs3ne1OH b6chWYq71/X2ANObBi7m/WzdnlYhI6W+5eZngBoOm43GvW2Y0trvYylsF864JD2SD7NC VCPZt9cXStblN+nEroUOaucrOiXD5jLqMrgpT6ww9ywRz6Sv1JS/ajzQOeyT0CU/BxRx M78UIeCUs7zekEYHMUhW1PEr0Rjy//JNOlEnVdXKoC8ugajDrNTyK4GMYgqsNdMQMY4S YBGg== MIME-Version: 1.0 X-Received: by 10.49.127.179 with SMTP id nh19mr1053986qeb.1.1381899272025; Tue, 15 Oct 2013 21:54:32 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.224.207.66 with HTTP; Tue, 15 Oct 2013 21:54:31 -0700 (PDT) In-Reply-To: References: Date: Tue, 15 Oct 2013 21:54:31 -0700 X-Google-Sender-Auth: RTvngcBhIEx0lYn7HjcKm5H_h8k Message-ID: Subject: Re: Correlation values for Atheros adaptive noise immunity From: Adrian Chadd To: w Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: "freebsd-wireless@freebsd.org" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Oct 2013 04:54:33 -0000 Hi! Thanks for reviewing this stuff! Please file (more) PRs with patches. I'll make sure these get fixed soon. Thanks! -adrian On 10 October 2013 21:01, w wrote: > With open source, we should be able to change it from "wrong" to "right" = :) > > I just spotted a little more bugs to be corrected: > \freebsd\sys\dev\ath\ath_hal\ar5416\ar5416_ani.c > Search "+1 <" (3 hits in 1 file) > Line 382: if (aniState->noiseImmunityLevel+1 < > params->maxNoiseImmunityLevel) { > Line 388: if (aniState->spurImmunityLevel+1 < > params->maxSpurImmunityLevel) { > Line 480: aniState->noiseImmunityLevel+1 < > params->maxNoiseImmunityLevel)) { > I think there shouldn=92t be a +1 before the the < sign because the > variables are integers. > > Thanks again for your help. > > ~ w ~ > > On Fri, Oct 11, 2013 at 9:34 AM, Adrian Chadd wrote: > > I don't have any open source PHY documentation. :) I'd have to write it= . > > > > Which isn't a bad thing; I'm happy to go and re-read what I (legally, > > legitimately!) have from Atheros about their PHY design and ANI and > write up > > what's implemented in the driver. > > > > The thing with ANI is that a lot of the parameters (like self-correlati= on > > thresholds) have to do with how signal detection in the PHY works. So > it's > > not specifically noise immunity as much as it's tweaking the sensitivit= y > > range and thresholds of the receiver hardware. > > > > There's some interesting things that should be re-investigated (ie, the > > m1/m2 thresholds and how weak signal detection works); I vaguely recall > when > > I was working there that ANI was doing it "wrong". I'll setup a meeting > or > > two with the PHY team when I'm back in California and jot down some > further > > notes about this. > > > > > > > > -adrian > > > > (note: so I'm legally allowed to have all this stuff and I'm legally > allowed > > to code up open source drivers with it, but what I can't do is share th= e > > documentation I have. So no, I won't share it. But whatever goes into > open > > source to improve their chips is open/fair game. Hence, I can write > > documentation and discuss whatever ends up in the open source drivers..= ) > > > > > > > > On 10 October 2013 18:30, w wrote: > >> > >> Do you have the open source link for the PHY documentation so I could > read > >> it? > >> > >> Actually my goal is quite simple I think: To test the effectiveness of > >> ANI. > >> > >> Thanks very much. > >> > >> ~ w ~ > >> > >> On Fri, Oct 11, 2013 at 4:43 AM, Adrian Chadd > wrote: > >> > Yeah, it's all a bit confusing. I'd have to re-read the PHY > >> > documentation i > >> > have here in order to really understand whta's going on. > >> > > >> > What are you trying to achieve herE? > >> > > >> > > >> > -adrian > >> > > >> > > >> > > >> > On 9 October 2013 20:03, w wrote: > >> >> > >> >> Update: looking at the patent again: > >> >> http://www.freepatentsonline.com/7349503.html > >> >> > >> >> Note that bb_m1thres and bb_m2thres refer to normalized, > >> >> self-correlated thresholds, bb_m2count_thr refers to the number of > >> >> self-correlation values (wherein a typical count would not exceed > 31), > >> >> and bb_use_self_corr_low refers to an enabling bit value. > >> >> > >> >> (but the variables are still quite confusing.) > >> >> > >> >> > >> >> ~ w ~ > >> >> > >> >> On Thu, Oct 10, 2013 at 10:12 AM, w wrote: > >> >> > Yup, I read the patent. I have also read the Atheros documentatio= n > >> >> > for > >> >> > ANI (for a different hardware version but it says the operation i= s > >> >> > similar). > >> >> > > >> >> > Are we able to see physical layer parameters like signal level / > >> >> > correlation / channel state information, > >> >> > or are they hidden inside the hardware? > >> >> > > >> >> > ~ w ~ > >> >> > > >> >> > > >> >> > > >> >> > On Thu, Oct 10, 2013 at 10:05 AM, Adrian Chadd > > >> >> > wrote: > >> >> >> I'm not sure. I think it's a signal level. Have you read the ANI > >> >> >> patent(s) ? > >> >> >> > >> >> >> > >> >> >> > >> >> >> -adrian > >> >> >> > >> >> >> > >> >> >> > >> >> >> On 9 October 2013 19:04, w wrote: > >> >> >>> > >> >> >>> Is there any way I can printk the correlation values for > >> >> >>> ar5416_ani.c? > >> >> >>> > >> >> >>> I couldn=92t find the variable that contains the correlation va= lue. > >> >> >>> Line 267 of the ar5416_ani.c file says: > >> >> >>> OS_REG_RMW_FIELD(ah, AR_PHY_SFCORR, > >> >> >>> AR_PHY_SFCORR_M1_THRESH, m1Thresh[on]); > >> >> >>> > >> >> >>> I don=92t know what the variables mean or what the function mea= ns > or > >> >> >>> what data type the variables are because I want to printk them. > >> >> >>> > >> >> >>> References: > >> >> >>> > >> >> >>> > >> >> >>> > >> >> >>> > >> >> >>> > http://svnweb.freebsd.org/base/head/sys/dev/ath/ath_hal/ar5416/ar5416_ani= .c?view=3Dmarkup > >> >> >>> > >> >> >>> > https://wiki.freebsd.org/dev/ath_hal%284%29/AutomaticNoiseImmunity > >> >> >>> > >> >> >>> ~ w ~ > >> >> >>> _______________________________________________ > >> >> >>> freebsd-wireless@freebsd.org mailing list > >> >> >>> http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > >> >> >>> To unsubscribe, send any mail to > >> >> >>> "freebsd-wireless-unsubscribe@freebsd.org" > >> >> >> > >> >> >> > >> >> _______________________________________________ > >> >> freebsd-wireless@freebsd.org mailing list > >> >> http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > >> >> To unsubscribe, send any mail to > >> >> "freebsd-wireless-unsubscribe@freebsd.org" > >> > > >> > > > > > >