From owner-svn-src-head@freebsd.org Thu Jun 1 15:28:53 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C3FCAFF6EA; Thu, 1 Jun 2017 15:28:53 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from mail.xcllnt.net (mail.xcllnt.net [50.0.150.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 555267E976; Thu, 1 Jun 2017 15:28:52 +0000 (UTC) (envelope-from marcel@xcllnt.net) Received: from marcels-mbp.int.brkt.com (cerberus.brkt.com [208.185.168.138]) (authenticated bits=0) by mail.xcllnt.net (8.15.2/8.15.2) with ESMTPSA id v51FBoLf069685 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 1 Jun 2017 08:11:51 -0700 (PDT) (envelope-from marcel@xcllnt.net) From: Marcel Moolenaar Message-Id: <78A8D734-A627-437D-AE63-BA94C543C36B@xcllnt.net> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Date: Thu, 1 Jun 2017 08:11:45 -0700 In-Reply-To: <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> Cc: Brooks Davis , Ngie Cooper , Marcel Moolenaar , "Simon J. Gerraty" , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org To: "Ngie Cooper (yaneurabeya)" References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> X-Mailer: Apple Mail (2.3273) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.xcllnt.net [50.0.150.214]); Thu, 01 Jun 2017 08:11:51 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 15:28:53 -0000 > On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya) = wrote: >=20 >=20 >> On May 31, 2017, at 10:03 PM, Brooks Davis = wrote: >>=20 >> On Wed, May 31, 2017 at 08:01:12AM +0000, Ngie Cooper wrote: >>> Author: ngie >>> Date: Wed May 31 08:01:12 2017 >>> New Revision: 319295 >>> URL: https://svnweb.freebsd.org/changeset/base/319295 >>>=20 >>> Log: >>> Update the usr.bin/mkimg golden test output files after = ^/head@r319125 >>>=20 >>> ^/head@r319125 changed the location of the backup pmbr, requiring = the >>> output files to be regenerated, since they're binary disk dumps. >>>=20 >>> The output files were regenerated with "make rebase"--fixed in >>> ^/head@r319294. >>=20 >> These should not be stored uuencoded. It serves no purpose other >> than bloating the repo and causing spammy commit mails like this one >> where we got a huge tail of garbage output. >=20 > Hi Brooks, > I=E2=80=99m not entirely sure why the files were uuencoded to be = honest. I think that=E2=80=99s a good question for Marcel and some of = the folks at Juniper, since they wrote the tool/tests. Result files used to start off as binary files. uuencoding is a given = in that case. I eventually switched to using hexdump -C, because that = makes it easier to analyze and understand differences. The uuencoding = was kept to remain independent of version control system, file = attributes and end-of-line characteristics of the host machine: nothing = more annoying that checking out textual result files and have test = failures because =E2=80=98\n=E2=80=99 was replaced by =E2=80=98\r\n=E2=80=99= . Even if the files aren=E2=80=99t unencoded, there=E2=80=99s always = someone who treats it as spammy and a tail of garbage. It=E2=80=99s just = a knee-jerk reaction to seeing something that isn=E2=80=99t understood, = I think. As such, there=E2=80=99s no reason to change =E2=80=94 in fact, = changing would be bloating the repo. --=20 Marcel Moolenaar marcel@xcllnt.net