From owner-freebsd-current@FreeBSD.ORG Tue Oct 29 08:56:17 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9FA116E7 for ; Tue, 29 Oct 2013 08:56:17 +0000 (UTC) (envelope-from tguldener@bluewin.ch) Received: from zhbdzmsp-smta17.bluewin.ch (zhbdzmsp-smta17.bluewin.ch [195.186.99.133]) by mx1.freebsd.org (Postfix) with ESMTP id 3CE762513 for ; Tue, 29 Oct 2013 08:56:16 +0000 (UTC) Received: from [195.186.227.131] ([195.186.227.131:48071] helo=zhhdzmsp-smta14.bluewin.ch) by zhbdzmsp-smta17.bluewin.ch (envelope-from ) (ecelerity 2.2.3.47 r(39824M)) with ESMTP id 2C/A0-10769-9287F625; Tue, 29 Oct 2013 08:56:10 +0000 Received: from [192.168.2.38] (213.3.48.228) by zhhdzmsp-smta14.bluewin.ch (8.5.142) (authenticated as tguldener@bluewin.ch) id 52330D9E03998AC1; Tue, 29 Oct 2013 08:56:09 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1812\)) Subject: Re: Shuttle DS47 - Realtek RT 8111G From: Thomas Guldener In-Reply-To: <20131029061417.GB1390@michelle.cdnetworks.com> Date: Tue, 29 Oct 2013 09:56:07 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <00FE0273-87E2-4812-8145-F98A31D5AE0B@bluewin.ch> References: <2F1C253C-BA52-4B5F-8DA9-0C15D46054A4@bluewin.ch> <206B1EDA-567F-4E58-AB71-AB91C4B8484B@samsco.org> <20130916021738.GA3619@michelle.cdnetworks.com> <4EA55409-2597-4931-B6B3-BF9DD11CD2EF@samsco.org> <20131029061417.GB1390@michelle.cdnetworks.com> To: pyunyh@gmail.com X-Mailer: Apple Mail (2.1812) X-Mailman-Approved-At: Tue, 29 Oct 2013 11:27:01 +0000 Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Oct 2013 08:56:17 -0000 Great news - thx for the work g. thomas On 29 Oct 2013, at 07:14, Yonghyeon PYUN wrote: > On Sun, Sep 15, 2013 at 09:04:28PM -0600, Scott Long wrote: >>=20 >> On Sep 15, 2013, at 8:17 PM, Yonghyeon PYUN wrote: >>=20 >>> On Sat, Sep 14, 2013 at 08:47:06PM -0600, Scott Long wrote: >>>> Index: sys/dev/re/if_re.c >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> --- sys/dev/re/if_re.c (revision 255582) >>>> +++ sys/dev/re/if_re.c (working copy) >>>> @@ -234,6 +234,10 @@ >>>> { RL_HWREV_8168E_VL, RL_8169, "8168E/8111E-VL", = RL_JUMBO_MTU_6K}, >>>> { RL_HWREV_8168F, RL_8169, "8168F/8111F", RL_JUMBO_MTU_9K}, >>>> { RL_HWREV_8411, RL_8169, "8411", RL_JUMBO_MTU_9K}, >>>> + { RL_HWREV_8168_0, RL_8169, "8168G/8111G", RL_JUMBO_MTU_9K}, >>>> + { RL_HWREV_8168_1, RL_8169, "8168G/8111G", RL_JUMBO_MTU_9K}, >>>> + { RL_HWREV_8168_2, RL_8169, "8168G/8111G", RL_JUMBO_MTU_9K}, >>>> + { RL_HWREV_8168_4, RL_8169, "8411", RL_JUMBO_MTU_9K}, >>>> { 0, 0, NULL, 0 } >>>> }; >>>>=20 >>>> @@ -1457,6 +1461,10 @@ >>>> case RL_HWREV_8168E_VL: >>>> case RL_HWREV_8168F: >>>> case RL_HWREV_8411: >>>> + case RL_HWREV_8168G_0: >>>> + case RL_HWREV_8168G_1: >>>> + case RL_HWREV_8168G_2: >>>> + case RL_HWREV_8168G_4: >>>> sc->rl_flags |=3D RL_FLAG_PHYWAKE | RL_FLAG_PAR | >>>> RL_FLAG_DESCV2 | RL_FLAG_MACSTAT | RL_FLAG_CMDSTOP | >>>> RL_FLAG_AUTOPAD | RL_FLAG_JUMBOV2 | >>>> Index: sys/pci/if_rlreg.h >>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >>>> --- sys/pci/if_rlreg.h (revision 255582) >>>> +++ sys/pci/if_rlreg.h (working copy) >>>> @@ -191,6 +191,10 @@ >>>> #define RL_HWREV_8402 0x44000000 >>>> #define RL_HWREV_8168F 0x48000000 >>>> #define RL_HWREV_8411 0x48800000 >>>> +#define RL_HWREV_8168G_0 0x4c000000 >>>> +#define RL_HWREV_8168G_1 0x4c100000 >>>=20 >>> I don't know exact model number for these MACs but it may be 8168G. >>>=20 >>>> +#define RL_HWREV_8168G_2 0x50900000 >>>=20 >>> This looks like 8168GU. >>>=20 >>>> +#define RL_HWREV_8168G_4 0x5c800000 >>>=20 >>> This looks like 8411B. >>>=20 >>> RL_TXCFG_HWREV is 0x7CC00000 so driver will not see >>> RL_HWREV_8168G_1(0x4c100000) and RL_HWREV_8168G_2(0x50900000). >>>=20 >>> It seems newer RealTek controllers seem to use ODP to access PHY. >>> In addition, these controllers may need to set RX DMA parameter >>> (bit 11 of RL_RXCFG). I'm not sure what this bit does though. >>>=20 >>> Scott, did you test your patch on real H/W? If it works I'm fine >>> with your patch. Just remove RL_HWREV_8168G_1 and RL_HWREV_8168G_2 >>> as current driver has no way to get these revisions. >>=20 >> I tested the 0x4c00000 on real hardware. an MSI Z87I motherboard. = The rest came from looking at the linux driver. That driver is = structured very differently (and better, IMHO) than the FreeBSD one, so = there's a lot that wasn't obvious to me. I'd be very happy to work more = on this with your guidance. >>=20 >=20 > FYI: Fixed in r257304-257306.