From owner-svn-src-all@freebsd.org Wed Jan 15 18:57:31 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 10EF01FA0C9; Wed, 15 Jan 2020 18:57:31 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47yc5Q6VcGz3MLr; Wed, 15 Jan 2020 18:57:30 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: by mail-yb1-xb2e.google.com with SMTP id x18so3101576ybk.6; Wed, 15 Jan 2020 10:57:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=UQ84bTjrqRSS+4Z4SUmgRRDkTIqgWObUQEtGG8k0BXE=; b=rz0Tl6eug7ZHLvgk2JC6vO1wkXuBXUSMmkYKQeQuI5Oht/zo7/xBctSjWoXdYjpTxV dtEm4s4goWfC4IC0k6CNI9KLnUMnIiYRXBdX+yXJPPwbSNyjrkIkbBP+5MxHKEDFxK0+ LrpyQwASpXGmA1Ur2NndsXwUqwbNp4GZRc3jdhAQ2i2/fqrT1YNTJwogVzzXZ1y8r+Ze yUu1wPP36mSa1HGm3szWydn+4/N6Y67znBVNC+6IV7r/aSAodn1jy62QGinUrsHqsb8r bhF4U/KuFwYxYvR0SRBoFOju9L5BdG3A5Ak266gFwx+s0ZwUEm6c11jpyB5juAQzf+Ij HeQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=UQ84bTjrqRSS+4Z4SUmgRRDkTIqgWObUQEtGG8k0BXE=; b=AlCkSJ6oE9uboj0k92llAdW1ch0orOQgSO4PHK3mpPej8kdtIH6jzUThuDKoj3aCSb G31UAkyYcLwXOUhQrIspjAbCTWrCmQHtdzFT0SNrWfemNlkTj4hE4IbeAnoxbsFoS0pX 8ux/IqzBAd+D7X1vNJF7w7UX0E3lbnvxOnA6GVOr3d9vasu8ujIbFN2ntTsfxC/eml1R KQwjcLFp32+C2OCPIuh3+3bfHVwqXBhW2ZonrnK93Jq0Wg/F5505bfctjMgOT7HdD6YR U1J1X5qYegGz4U2pux76BP8c4/AJQfONjFocWipySoYsXBvZr3m9gQJ3x2JEuH/wHfs7 iB3A== X-Gm-Message-State: APjAAAVB6rRzP5tglg2RJLji8+GXya+DunoD/5PhgKe8w7Skf2BUaLVy +ZMpC/aLNnBq5L9od+iceDc5KYA8exUefumIbIkwDQ== X-Google-Smtp-Source: APXvYqw95GUsN7lfazVT8mflEBPbEH9ygNne0rS7tJhgCeJTWDU18rpTBEydl8dk8wcC0YrMWgwwwaMS/aRtcTzflP4= X-Received: by 2002:a25:9244:: with SMTP id e4mr14610475ybo.461.1579114649420; Wed, 15 Jan 2020 10:57:29 -0800 (PST) MIME-Version: 1.0 Received: by 2002:a25:3816:0:0:0:0:0 with HTTP; Wed, 15 Jan 2020 10:57:28 -0800 (PST) In-Reply-To: <202001150747.00F7lqiG071097@repo.freebsd.org> References: <202001150747.00F7lqiG071097@repo.freebsd.org> From: Oliver Pinter Date: Wed, 15 Jan 2020 19:57:28 +0100 Message-ID: Subject: Re: svn commit: r356758 - in head/usr.sbin/bsdinstall: . scripts To: Ben Woods Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" , Ed Maste X-Rspamd-Queue-Id: 47yc5Q6VcGz3MLr X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jan 2020 18:57:31 -0000 On Wednesday, January 15, 2020, Ben Woods wrote: > Author: woodsb02 (ports committer) > Date: Wed Jan 15 07:47:52 2020 > New Revision: 356758 > URL: https://svnweb.freebsd.org/changeset/base/356758 > > Log: > bsdinstall: Change "default" (first) Partitioning method to ZFS > > Reported by: Ruben Schade (during his talk at linux.conf.au) > Approved by: philip > Differential Revision: https://reviews.freebsd.org/D23173 What's the justification behind this change? Plus I miss from here the relontes tag. > > Modified: > head/usr.sbin/bsdinstall/bsdinstall.8 > head/usr.sbin/bsdinstall/scripts/auto > > Modified: head/usr.sbin/bsdinstall/bsdinstall.8 > ============================================================ > ================== > --- head/usr.sbin/bsdinstall/bsdinstall.8 Wed Jan 15 06:18:32 2020 > (r356757) > +++ head/usr.sbin/bsdinstall/bsdinstall.8 Wed Jan 15 07:47:52 2020 > (r356758) > @@ -119,7 +119,7 @@ Provides the installer's interactive guided disk parti > installations. > Defaults to UFS. > .It Cm zfsboot > -Provides an alternative ZFS-only automatic interactive disk partitioner. > +Provides a ZFS-only automatic interactive disk partitioner. > Creates a single > .Ic zpool > with separate datasets for > > Modified: head/usr.sbin/bsdinstall/scripts/auto > ============================================================ > ================== > --- head/usr.sbin/bsdinstall/scripts/auto Wed Jan 15 06:18:32 2020 > (r356757) > +++ head/usr.sbin/bsdinstall/scripts/auto Wed Jan 15 07:47:52 2020 > (r356758) > @@ -289,7 +289,7 @@ Shell \"Open a shell and partition by hand\"" > CURARCH=$( uname -m ) > case $CURARCH in > amd64|arm64|i386) # Booting ZFS Supported > - PMODES="$PMODES \"Auto (ZFS)\" \"Guided Root-on-ZFS\"" > + PMODES="\"Auto (ZFS)\" \"Guided Root-on-ZFS\" $PMODES" > ;; > *) # Booting ZFS Unspported > ;; > @@ -303,6 +303,10 @@ PARTMODE=`echo $PMODES | xargs dialog --backtitle "Fre > exec 3>&- > > case "$PARTMODE" in > +"Auto (ZFS)") # ZFS > + bsdinstall zfsboot || error "ZFS setup failed" > + bsdinstall mount || error "Failed to mount filesystem" > + ;; > "Auto (UFS)") # Guided > bsdinstall autopart || error "Partitioning error" > bsdinstall mount || error "Failed to mount filesystem" > @@ -319,10 +323,6 @@ case "$PARTMODE" in > else > bsdinstall partedit || error "Partitioning error" > fi > - bsdinstall mount || error "Failed to mount filesystem" > - ;; > -"Auto (ZFS)") # ZFS > - bsdinstall zfsboot || error "ZFS setup failed" > bsdinstall mount || error "Failed to mount filesystem" > ;; > *) > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >