From owner-svn-src-head@freebsd.org Wed May 3 23:05:12 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B6CEAD565F5 for ; Wed, 3 May 2017 23:05:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x241.google.com (mail-it0-x241.google.com [IPv6:2607:f8b0:4001:c0b::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6E26CFE3 for ; Wed, 3 May 2017 23:05:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x241.google.com with SMTP id x188so517894itb.3 for ; Wed, 03 May 2017 16:05:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=l2FRTF69E6+CpunT3F3aJ5WgFB9YdsqmjKMH0twjoWE=; b=jst2hYOdqebEFW41OH/U74gZVoyBGkAIF9qyihdv6grJuACBoY/1IPdsQAtv/1BklI ItI8KJy1fWlUBepRCXpiv6m50glueYfgHTnav8hZ9b6/2j6oWHA+zFZBFuaaLuw5EHLZ gOsGhSS0E9uBYXBVk8mfEV7K+FW88O7Ro/68FY2BlDh9Co3QYS1auZSPR94MD0kmypGt CiPJC2Al6zDpbFAvmFb+6fb4yKepBUOMK4XkmftwcSvM7UwfUF2UvyaDde/3DT/zlGLb 1dGROWe8BcHQCRkHjguTlPvVJ6hC3/f/QFELcum8afsThDVscwoxY5OEoLSqIKtR5D+W YFRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=l2FRTF69E6+CpunT3F3aJ5WgFB9YdsqmjKMH0twjoWE=; b=dYTFriv2jc6Mrix4q98hrn7zVC1u16R6xw3foF8DOxosUW7Kxicx3cXpj5ZNAjiBpw iJuzgj1vlVMHNHD4Tl45ahK6hCdfozc/0BqO6zunaRW3ioWxshYDgRjcmacXLB4xOz5/ ru5thuJBzd74O9PX/w2z/7R5ADhrlORntJB7VDZmtTU9F7UE4+PAKEDlrOI0D4Z6I5Xp GaIBBbFt35XamgsmbCB1drDoFaVsalwiLmEzoqVOY3AnntbfB8ZmV3wCK3vUB38EvWEC I81TglCVUZcgYAo60hYkraNAMrCno29W8uiXHWrg/n90NzDsMc3dnTrKLKDeyRdxJJqM B0Uw== X-Gm-Message-State: AN3rC/6/jP4OxtW/SDa6guLAMc/5hZd1QV+nGCL68abweebrhplwYqL1 J+ajrOdBVTOjpJSCuScZSiE6cqrFlg== X-Received: by 10.36.6.142 with SMTP id 136mr3567541itv.0.1493852711736; Wed, 03 May 2017 16:05:11 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.126.6 with HTTP; Wed, 3 May 2017 16:04:13 -0700 (PDT) X-Originating-IP: [2607:fb10:7021:1::44a] In-Reply-To: References: <201705031721.v43HL2vS071819@repo.freebsd.org> <1493838199.80042.14.camel@freebsd.org> From: Warner Losh Date: Wed, 3 May 2017 17:04:13 -0600 X-Google-Sender-Auth: FCCJEYip6O-18m2jbs_Tnte2Bxo Message-ID: Subject: Re: svn commit: r317755 - head/sbin/ifconfig To: "Andrey V. Elsukov" Cc: Alan Somers , Ian Lepore , Ryan Stone , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 May 2017 23:05:12 -0000 On Wed, May 3, 2017 at 4:50 PM, Andrey V. Elsukov wrote: > On 03.05.2017 22:22, Alan Somers wrote: >> The problem with the original code is that module load errors would be >> caught too late, and as a result the error printed would be less >> useful. For example, if you forgot to put "kld_list=if_igb" in >> /etc/rc.conf and run "ifconfig igb0", it would print "ifconfig: >> interface igb7 does not exist" instead of the more useful "ifconfig: >> kldload(if_igb): Operation not permitted". But I didn't know that >> there were drivers like mlx4en where ifconfig can't load the correct >> module. So I'll take Ryan's suggestion and revert that part for now. > > I want to note, that there is if_enc(4) kernel module, that is failed to > be loaded by ifconfig(8) due to presence in the kernel enc(4) driver > (from sys/cam). There shouldn't be two drivers with the same name. That's a bug, but it's been like this for 4 years... Warner