From owner-svn-src-stable@FreeBSD.ORG Fri Sep 24 21:15:21 2010 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 69F35106566B for ; Fri, 24 Sep 2010 21:15:21 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 113E58FC16 for ; Fri, 24 Sep 2010 21:15:20 +0000 (UTC) Received: (qmail 9015 invoked by uid 399); 24 Sep 2010 20:48:40 -0000 Received: from localhost (HELO ?192.168.0.142?) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 24 Sep 2010 20:48:40 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4C9D0EA7.1060900@FreeBSD.org> Date: Fri, 24 Sep 2010 13:48:39 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.9) Gecko/20100915 Thunderbird/3.1.4 MIME-Version: 1.0 To: Rui Paulo References: <201009221800.o8MI0Ze3038214@svn.freebsd.org> <20100923070247.L716@delplex.bde.org> <3CC9503B-35BA-4637-8909-CBC6674ACDDA@freebsd.org> In-Reply-To: <3CC9503B-35BA-4637-8909-CBC6674ACDDA@freebsd.org> X-Enigmail-Version: 1.2a1pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org, Bruce Evans Subject: Re: svn commit: r213002 - in stable/8: include lib/libc/gen X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Sep 2010 21:15:21 -0000 On 9/23/2010 11:14 PM, Rui Paulo wrote: > On 22 Sep 2010, at 22:08, Bruce Evans wrote: > >> On Wed, 22 Sep 2010, Rui Paulo wrote: >> >>> Log: >>> MFC r197804 (rwatson): >>> Add basename_r(3) to complement basename(3). basename_r(3) which accepts >>> a caller-allocated buffer of at least MAXPATHLEN, rather than using a >>> global buffer. >> >> MAXPATHLEN has been deprecated for more than 20 years. Please don't use >> it in new interfaces. A few man pages, not including basename.3, have >> been updated to spell it PATH_MAX (should be {PATH_MAX}). > > I'm not going to fix this because the interface will most likely change to something that doesn't require PATH_MAX. But thanks for pointing this out. There are 2 possibilities. The first is that you do actually fix it soon, in which case the change Bruce asked for is harmless churn. This is common and accepted in HEAD. The other possibility (which happens to us all) is that the intended fixup never occurs, so the inappropriate code lingers and is ultimately forgotten. The potential cost in this case is much higher than the potential cost of some harmless churn. Bonus points if someone copies and pastes your code in the intervening period. Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/