Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Mar 2008 09:59:05 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Alejandro Pulver <alepulver@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/games/alienarena Makefile distinfo pkg-descr pkg-message ports/games/alienarena/files alienarena-ded.in alienarena-sdl.in alienarena.in patch-Makefile patch-client__menu.c patch-game__acesrc__acebot.h patch-game__acesrc__acebot_nodes.c ...
Message-ID:  <20080325095905.GA16355@FreeBSD.org>
In-Reply-To: <200803242042.m2OKgSmG034282@repoman.freebsd.org>
References:  <200803242042.m2OKgSmG034282@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 24, 2008 at 08:42:28PM +0000, Alejandro Pulver wrote:
> alepulver    2008-03-24 20:42:28 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     games/alienarena     Makefile distinfo pkg-descr pkg-message 
>     games/alienarena-data Makefile distinfo pkg-descr pkg-plist 
>   Removed files:
>     games/alienarena/files alienarena-ded.in alienarena-sdl.in 
>                            alienarena.in patch-Makefile 
>                            patch-client__menu.c 
>                            patch-game__acesrc__acebot.h 
>                            patch-game__acesrc__acebot_nodes.c 
>                            patch-game__acesrc__acebot_spawn.c 
>                            patch-qcommon__files.c 
>                            patch-ref_gl__qgl.h 
>                            patch-ref_gl__r_script.c 
>   Log:
>   Both data and program:
>   - Update to version 2008.
>   
>   Only for games/alienarena:
>   - Remove local patches (now integrated upstream).
>   - Check for WITH_* instead of !WITHOUT_* (avoid double negation).

I've been under impression that common practice is to check for WITH_FOO
with knobs that are default to off, and !WITHOUT_FOO that default to on.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080325095905.GA16355>