From owner-svn-src-all@FreeBSD.ORG Tue Dec 31 03:49:41 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1663372A for ; Tue, 31 Dec 2013 03:49:41 +0000 (UTC) Received: from nm8-vm0.bullet.mail.bf1.yahoo.com (nm8-vm0.bullet.mail.bf1.yahoo.com [98.139.213.95]) by mx1.freebsd.org (Postfix) with SMTP id 9CCA71CCB for ; Tue, 31 Dec 2013 03:49:40 +0000 (UTC) Received: from [98.139.215.143] by nm8.bullet.mail.bf1.yahoo.com with NNFMP; 31 Dec 2013 03:49:33 -0000 Received: from [68.142.230.69] by tm14.bullet.mail.bf1.yahoo.com with NNFMP; 31 Dec 2013 03:49:33 -0000 Received: from [127.0.0.1] by smtp226.mail.bf1.yahoo.com with NNFMP; 31 Dec 2013 03:49:33 -0000 X-Yahoo-Newman-Id: 412209.9915.bm@smtp226.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: pffOzqsVM1k4vZ9_HlITKy2U9WJqOpNa0FH4zIkMaiRJxeK Hu_Z5acsQ0EF.MKnUufr3Jkq4u1pWOmg7W6bLN7ti.LO_3ggZ9.oDJj_DCsU puNhNUX9mUtHMAo_SkrJqhGOSvERhBauimm5IT8Kt6hc0gwS54ciFr3pj5Sj 2XFRWNIMUluEqrDhnoxbjNiwaxip92nBEK1w_zp_Xlp1qpYaGzWC1zqcfp.e oO24.49RHgN4IIMs2j5wmwtm4dgTAaBQ6nGyFXm8GqImkrVDrgWm3hj_7uWr CHGaFqn2dYh3pdvFD97u6_WdA._ig_3wM_B.K8hbm9MqWG5NjD1LO6v7GAKO __Wv4DkGPD1ZMJOwtgWihoBK65C7PlsFILqqZwK0fbcGZ1T1jG4ZE._MqMWY ig6mfD2zCWGM1Jp8iSBZg27.KVyj4oAzFe4w9pvnZQ0u8D6VhwA9fOgxUDad RWDQpn.hYNbunhPGsnxhlHmuW6Fky6T0CgU57RgTZY_Kqkg35iz56RwNq0Qc yZboFoypB0SN87L42mUHr9Z02t_Lc.Yhbecxou8h.iZYW7VdLKek- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf X-Rocket-Received: from [192.168.0.101] (pfg@190.157.126.109 with plain [98.139.211.125]) by smtp226.mail.bf1.yahoo.com with SMTP; 31 Dec 2013 03:49:33 +0000 UTC Mime-Version: 1.0 (Mac OS X Mail 7.0 \(1822\)) Subject: Re: svn commit: r260091 - in head/sys/cddl: contrib/opensolaris/uts/common/dtrace contrib/opensolaris/uts/common/sys dev/dtrace From: Pedro Giffuni In-Reply-To: <20131231032845.GB11997@charmander.home> Date: Mon, 30 Dec 2013 22:49:23 -0500 Message-Id: References: <201312301737.rBUHbW3I035088@svn.freebsd.org> <20131230204210.GD71033@FreeBSD.org> <20131231023952.GA11997@charmander.home> <7A335B4A-D986-4E6E-8D8B-22E7E7991A75@FreeBSD.org> <20131231032845.GB11997@charmander.home> To: Mark Johnston X-Mailer: Apple Mail (2.1822) Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , Mike Ma , src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Dec 2013 03:49:41 -0000 Il giorno 30/dic/2013, alle ore 22:28, Mark Johnston = ha scritto: > On Mon, Dec 30, 2013 at 10:21:58PM -0500, Pedro Giffuni wrote: >>=20 >> Il giorno 30/dic/2013, alle ore 21:40, Mark Johnston = ha scritto: >>=20 >>> On Tue, Dec 31, 2013 at 12:42:10AM +0400, Gleb Smirnoff wrote: >>>> On Mon, Dec 30, 2013 at 05:37:32PM +0000, Mark Johnston wrote: >>>> M> Author: markj >>>> M> Date: Mon Dec 30 17:37:32 2013 >>>> M> New Revision: 260091 >>>> M> URL: http://svnweb.freebsd.org/changeset/base/260091 >>>> M>=20 >>>> M> Log: >>>> M> Now that vmem(9) is available, use vmem arenas to allocate = probe and >>>> M> aggregation IDs, as is done in the upstream illumos code. This = still >>>> M> requires some FreeBSD-specific code, as our vmem API is not = identical to the >>>> M> one in illumos. >>>> M> =20 >>>> M> Submitted by: Mike Ma >>>>=20 >>>> IMHO, alloc_unr() was lighter and thus better for allocating just = IDs. >>>=20 >>> That's true; I committed the change since it helps keep our code = similar >>> to upstream and, as Pedro notes, it was a long-standing todo item on = the >>> wiki. After doing some testing, it looks like vmem is a bit slower: >>> process startup is on the order of tenths of milliseconds longer = with >>> this change, for executables containing one USDT probe (since such >>> probes are allocated during process startup). >>>=20 >>> So probably the right thing to do is revert this change. It doesn't >>> actually reduce the upstream diff as much as I'd hoped, anyway. >>>=20 >>=20 >> Since it is our option to decide, perhaps just keep the vmem version = as reference and #ifdef FreeBSD alloc_unr() ? >=20 > You mean just having >=20 > #if defined(sun) > vmem code > #else > *_unr code > #endif >=20 > ? That's what we'd get by reverting the change. Rather=20 #ifdef __FreeBSD__ *_unr code #else vmem code (FreeBSD variant) #endif Not much different, but if we are going to keep dead code let=92s keep = at least code that is known to work ;) Pedro.=