From owner-cvs-src@FreeBSD.ORG  Sat Jun 21 10:43:25 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0498137B401; Sat, 21 Jun 2003 10:43:25 -0700 (PDT)
Received: from critter.freebsd.dk (port757.uc1-esp.isdn-lan.cybercity.dk
	[212.242.98.245])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2606D43FAF; Sat, 21 Jun 2003 10:43:23 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h5LHh5RJ001198;
	Sat, 21 Jun 2003 19:43:06 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: "Sam Leffler" <sam@errno.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sat, 21 Jun 2003 10:16:11 PDT."
             <00de01c33818$cff31210$52557f42@errno.com> 
Date: Sat, 21 Jun 2003 19:43:05 +0200
Message-ID: <1197.1056217385@critter.freebsd.dk>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/vm vm_mmap.c 
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jun 2003 17:43:25 -0000

In message <00de01c33818$cff31210$52557f42@errno.com>, "Sam Leffler" writes:
>> phk         2003/06/21 01:27:06 PDT
>> 
>>   FreeBSD src repository
>> 
>>   Modified files:
>>     sys/vm               vm_mmap.c 
>>   Log:
>>   Use a do {...} while (0); and a couple of breaks to reduce the level
>>   of indentation a bit.
>>   
>>   Revision  Changes    Path
>>   1.161     +80 -78    src/sys/vm/vm_mmap.c
>> http://cvsweb.FreeBSD.org/src/sys/vm/vm_mmap.c.diff?r1=1.160&r2=1.161
>
>I find this change truly repulsive and gratuitous.

It is a precusor to moving devices out of vnodes.  In order to get the
patch which _does_ something to be manageable, I will sort out some
minor issues first, this is one of them.

If your complaint is about the use of do { ... break; ... break; }
while (0); then launch an campaign to have it banned in style 9.

IMO it is superior to goto, and ever deepening if-else constructs.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.