From owner-cvs-all@FreeBSD.ORG Tue Dec 12 14:37:37 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C8B2E16A412; Tue, 12 Dec 2006 14:37:37 +0000 (UTC) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B91D43F99; Tue, 12 Dec 2006 14:23:24 +0000 (GMT) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.11/8.13.6) with ESMTP id kBCEOjkw061929; Tue, 12 Dec 2006 06:24:45 -0800 (PST) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.11/8.12.3/Submit) id kBCEOjgO061928; Tue, 12 Dec 2006 06:24:45 -0800 (PST) (envelope-from rizzo) Date: Tue, 12 Dec 2006 06:24:45 -0800 From: Luigi Rizzo To: ticso@cicely.de Message-ID: <20061212062445.A61903@xorpc.icir.org> References: <200612081036.kB8AakMD029277@repoman.freebsd.org> <20061212131333.GU54209@cicely12.cicely.de> <20061212055756.A61182@xorpc.icir.org> <20061212141759.GZ54209@cicely12.cicely.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20061212141759.GZ54209@cicely12.cicely.de>; from ticso@cicely12.cicely.de on Tue, Dec 12, 2006 at 03:17:59PM +0100 Cc: cvs-src@FreeBSD.org, Luigi Rizzo , src-committers@FreeBSD.org, imp@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_ethersubr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2006 14:37:38 -0000 On Tue, Dec 12, 2006 at 03:17:59PM +0100, Bernd Walter wrote: > On Tue, Dec 12, 2006 at 05:57:56AM -0800, Luigi Rizzo wrote: ... > > then i suppose the proper fix is to revert to m_copy() and > > work on if_simloop() so that 1. it handles a readonly chain, and > > 2. when doing so, it passes up a properly aligned packet... > > Can't comment on this, as I don't have enough knowledge about network > code. > According to the xscale report it was likely never properly aligned, > the alignment obviously just moved with your change. > > > however note that there is already some code in net/if_loop.c::if_simloop(), > > just that it uses this: > > > > #if defined(__ia64__) || defined(__sparc64__) ... > > to detect whether the architecture is alignment-sensitive. > > Is there any other identifier that we can use to check ? > > I wonder how many of these are missing __arm__? and this is why i wonder if there is a generic identifier that we can use to provide alignment. cheers luigi