From owner-freebsd-hackers Mon Apr 13 10:01:11 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA05616 for freebsd-hackers-outgoing; Mon, 13 Apr 1998 10:01:11 -0700 (PDT) (envelope-from owner-freebsd-hackers@FreeBSD.ORG) Received: from jraynard.demon.co.uk (jraynard.demon.co.uk [158.152.42.77]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA05607 for ; Mon, 13 Apr 1998 17:01:02 GMT (envelope-from fhackers@jraynard.demon.co.uk) Received: (from fhackers@localhost) by jraynard.demon.co.uk (8.8.8/8.8.8) id QAA03910; Mon, 13 Apr 1998 16:06:04 +0100 (BST) (envelope-from fhackers) Message-ID: <19980413160603.35279@jraynard.demon.co.uk> Date: Mon, 13 Apr 1998 16:06:03 +0100 From: James Raynard To: rotel@indigo.ie Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: PR kern/1144 References: <199804131247.NAA01565@indigo.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.81e In-Reply-To: <199804131247.NAA01565@indigo.ie>; from Niall Smart on Mon, Apr 13, 1998 at 01:47:14PM +0000 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, Apr 13, 1998 at 01:47:14PM +0000, Niall Smart wrote: > > The abovementioned PR is for sig{add, del}set and sigismember. > Apparently POSIX requires that these functions check that the > specified signal number exists, which they currently do not do. Ah yes, that was one I submitted so long ago I'd forgotten about the email account I sent it from. :-) BTW if whoever was responsible for the weekly mailing of outstanding PRs is reading this, is there any chance of getting it back? > These functions are currently defined as macro's, I don't see any > nice, fast, MT-safe way that only evaluates the signal number > argument once that adds the checking that POSIX requires while > keeping them as macros. I very much doubt that one exists. > So should I submit patches to fix this > problem by deleting the macro definitions and adding the required > checking to /usr/src/lib/libc/gen/sigsetops.c or are we going to > ignore POSIX? The consensus seemed to be that there was no easy way to do it, so we've been ignoring POSIX ever since (in that respect at least) :-) Incidentally, I've been working on some patches to get around the NSIG==32 limit. I've done most of the "boring" work, but there are a few things left over that I don't really know enough to handle: 1. Emacs breaks (albeit an old version - 19.29). Everything else I've tried works, including linuxxdoom. 2. I had to add an extra system call osigprocmask for the compat stuff which does exactly what the old sigprocmask call used to do. This makes upgrading to the new code a real pain. 3. Could probably do with optimising, as well. Not to mention the usual stylistic/code management issues... Anyone care to help me out? James To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message