From owner-freebsd-ports@FreeBSD.ORG Sat Jan 17 21:43:41 2015 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7A896FD5 for ; Sat, 17 Jan 2015 21:43:41 +0000 (UTC) Received: from mail-we0-x22b.google.com (mail-we0-x22b.google.com [IPv6:2a00:1450:400c:c03::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0B4FAD05 for ; Sat, 17 Jan 2015 21:43:41 +0000 (UTC) Received: by mail-we0-f171.google.com with SMTP id u56so25578634wes.2 for ; Sat, 17 Jan 2015 13:43:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=9iuoOS/cOJb/kqpoVQ4ot/zdNbaGW7VDVRscYXLfUbY=; b=Qt2d/lQ2B8FmkDMDMjbqM1Uk/iBvZuWrdpGrzyr3INPInJUwgKmUiw3WBr0bWeCqFG wdm2WdnNNrLyDu5k/PKQLpN1sNYT7yMGQNfHvpiqV3598P81t2XaT3AnSyNXUcGC6URP dLFOChDy2bTBtw2wE91n8bD26LKLSHOpsaOqtu46TOiM9e2vV1Sm8DBxyx3osbCuiBEz aCs5SFEIK6s2adDgO6MbiowkAzdGqEYpcA09k+HJhYtIdVZaaKtRPY8P7hXlhqRJl/Lc m687+4mHYlrp61TmKWHqt8D8B7K+C0ZdBoZV/GQXOfqDm33d8/Qy7gyhDs28gFz4jIQj QStg== MIME-Version: 1.0 X-Received: by 10.180.20.6 with SMTP id j6mr19115094wie.59.1421531019464; Sat, 17 Jan 2015 13:43:39 -0800 (PST) Received: by 10.27.131.166 with HTTP; Sat, 17 Jan 2015 13:43:39 -0800 (PST) In-Reply-To: References: <20150117165844.GS44537@home.opsec.eu> <20150117182525.GU44537@home.opsec.eu> Date: Sat, 17 Jan 2015 15:43:39 -0600 Message-ID: Subject: Re: updating alpine port to new version (as a maintainer) From: Scot Hetzel To: Marco Beishuizen Content-Type: text/plain; charset=ISO-8859-1 Cc: Kurt Jaeger , FreeBSD Ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Jan 2015 21:43:41 -0000 On Sat, Jan 17, 2015 at 2:54 PM, Marco Beishuizen wrote: > On Sat, 17 Jan 2015, the wise Scot Hetzel wrote: > >> On line 41 of the current ports Makefile, it shows tech-notes.txt: >> >> 41 PORTDOCSdoc= brochure.txt tech-notes.txt >> >> Then on lines 163-164 in the post-install stage it tries to install them: >> >> 163 .for f in ${PORTDOCSdoc} >> 164 ${INSTALL_MAN} ${WRKSRC}/doc/$f ${STAGEDIR}${DOCSDIR} >> 165 .endfor >> >> Change the PORTDOCSdoc variable to: >> >> PORTDOCSdoc= brochure.txt tech-notes/tech-notes.txt >> >> This should install the tech-notes.txt file into the ${DOCSDIR}. >> >> The other option is to remove tech-notes.txt from PORTDOCSdoc and >> added it to PORTDOCShtml. Then update the pkg-plist for the new >> location. > > > Thank you too Scot for your help. After adjusting these lines (and also one > in line 145) this part seems to work. > > Now it gives a compile error and a lot of warnings during compiling. > > The 2 errors are: > > maildir.c:1720:66: error: too few arguments to function call, expected 2, > have 1 > if (maildir_canonicalize (test, ref, pat) && (s = sm_read (&sdb))) { > ~~~~~~~ ^ > maildir.c:1722:30: error: too few arguments to function call, expected 2, > have 1 > while ((s = sm_read (&sdb)) != NULL); /* until no more subscriptions */ > > Are you using the correct version of the maildir.patch.gz. If you look on line 116 of the original Makefile, it shows: 116 PATCH_SITES= http://patches.freeiz.com/alpine/patches/alpine-2.11/ 117 PATCHFILES+= maildir.patch.gz You should change that line so that it shows alpine-2.20 or alpine-${PORTVERSION} instead. I checked the alpine-2.20/maildir.patch.gz and it shows that sm_read requires 2 arguments. Since the patch file isn't versioned, you will have to remove the file from your distfiles and run make checksum to update the checksum for the file. Another option is to change lines 116 and 117 to: 116 PATCH_SITES= http://patches.freeiz.com/alpine/patches/ 117 PATCHFILES+= alpine-${PORTVERSION}/maildir.patch.gz This will ensure everyone has the correct version of the maildir.patch.gz file. -- DISCLAIMER: No electrons were maimed while sending this message. Only slightly bruised.