From owner-svn-src-head@freebsd.org  Wed Jan 11 07:17:04 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E554CAA5B1;
 Wed, 11 Jan 2017 07:17:04 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 2F9771FF6;
 Wed, 11 Jan 2017 07:17:04 +0000 (UTC)
 (envelope-from ngie@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id v0B7H3QO031631;
 Wed, 11 Jan 2017 07:17:03 GMT (envelope-from ngie@FreeBSD.org)
Received: (from ngie@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id v0B7H30W031630;
 Wed, 11 Jan 2017 07:17:03 GMT (envelope-from ngie@FreeBSD.org)
Message-Id: <201701110717.v0B7H30W031630@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: ngie set sender to
 ngie@FreeBSD.org using -f
From: Ngie Cooper <ngie@FreeBSD.org>
Date: Wed, 11 Jan 2017 07:17:03 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r311917 - head/contrib/netbsd-tests/lib/libc/gen
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Jan 2017 07:17:04 -0000

Author: ngie
Date: Wed Jan 11 07:17:03 2017
New Revision: 311917
URL: https://svnweb.freebsd.org/changeset/base/311917

Log:
  Fix up r311227
  
  Check for creat returning a value != -1, not a non-zero value
  
  MFC after:	3 days
  Pointyhat to:	ngie
  Reported by:	Coverity
  CID:		1368366

Modified:
  head/contrib/netbsd-tests/lib/libc/gen/t_dir.c

Modified: head/contrib/netbsd-tests/lib/libc/gen/t_dir.c
==============================================================================
--- head/contrib/netbsd-tests/lib/libc/gen/t_dir.c	Wed Jan 11 06:01:23 2017	(r311916)
+++ head/contrib/netbsd-tests/lib/libc/gen/t_dir.c	Wed Jan 11 07:17:03 2017	(r311917)
@@ -59,12 +59,12 @@ ATF_TC_BODY(seekdir_basic, tc)
 	long here;
 
 #ifdef	__FreeBSD__
-#define	CREAT(x, m)	do {					\
-		int _creat_fd;					\
-		ATF_REQUIRE_MSG((_creat_fd = creat((x), (m))),	\
-		    "creat(%s, %x) failed: %s", (x), (m),	\
-		    strerror(errno));				\
-		(void)close(_creat_fd);			\
+#define	CREAT(x, m)	do {						\
+		int _creat_fd;						\
+		ATF_REQUIRE_MSG((_creat_fd = creat((x), (m))) != -1,	\
+		    "creat(%s, %x) failed: %s", (x), (m),		\
+		    strerror(errno));					\
+		(void)close(_creat_fd);					\
 	} while(0);
 
 	ATF_REQUIRE_MSG(mkdir("t", 0755) == 0,