From owner-svn-src-projects@FreeBSD.ORG Mon Jul 30 15:04:18 2012 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 4C011106566C; Mon, 30 Jul 2012 15:04:18 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 285E78FC08; Mon, 30 Jul 2012 15:04:16 +0000 (UTC) Received: by lbon10 with SMTP id n10so4272166lbo.13 for ; Mon, 30 Jul 2012 08:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=OR3niMb/O7ESx0RYD6jhj/8pEXJFjje9GPQYDFCAYp4=; b=XtUM/P3rCmtkuR9fli4DRwMV+T+i9/C3fKJU7vqKt3k40B4yNaQn4llWXuqWXeuB1K v4OwzNk5QBxNQXmlRsgIqsnjduIjjxfd12sCPBm9B8buKFu9hWRaGBZZUNsCIYnf2tsZ eoYtalBTg3MZv/32B8k51FlwbA42fSkWPDV3ZYTRcwbBP625UUmOahVW+wggLpQi9VXJ /dI1ON2JsWnAA20r9KdWZaoZGyf5vP5yPDCKcrgBCvry3Yw4EJ4GEBkf/aZdUDU/yXau icY0VIdDkAz6VGAYAzllvyubKG70zqIgVYZDnw46B6fA7k0lP+HvsMpwAVYNdHpeTzQ0 L05Q== MIME-Version: 1.0 Received: by 10.152.103.11 with SMTP id fs11mr11694840lab.23.1343660655883; Mon, 30 Jul 2012 08:04:15 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.27.65 with HTTP; Mon, 30 Jul 2012 08:04:15 -0700 (PDT) In-Reply-To: <5016A21B.6090409@FreeBSD.org> References: <201207301350.q6UDobCI099069@svn.freebsd.org> <20120730143943.GY2676@deviant.kiev.zoral.com.ua> <5016A21B.6090409@FreeBSD.org> Date: Mon, 30 Jul 2012 16:04:15 +0100 X-Google-Sender-Auth: GUM9FruT3Y8fvZtP760sDUgTtM0 Message-ID: From: Attilio Rao To: Andriy Gapon Content-Type: text/plain; charset=UTF-8 Cc: Konstantin Belousov , Davide Italiano , src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: Re: svn commit: r238907 - projects/calloutng/sys/kern X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2012 15:04:18 -0000 On 7/30/12, Andriy Gapon wrote: > on 30/07/2012 17:56 Attilio Rao said the following: >> More explicitly, I think such combination TDP_NOSLEEPING + >> TDP_NOBLOCKING (name invented) should be set on entering the interrupt >> context, not only related to this part of callouts. This would be a >> very good help for catching buggy situations. > > Something very tangential. I think it would also be nice to check if a > thread has > any(?) locks held when returning to userland. This happens already for INVARIANTS case, with td_locks counters. In the !INVARIANTS case, this doesn't happen because you don't want to add the burden to bump td_locks for the fast case and I think it is a good approach. Attilio -- Peace can only be achieved by understanding - A. Einstein