From owner-svn-src-head@FreeBSD.ORG Thu Sep 18 11:21:06 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3C1596A7; Thu, 18 Sep 2014 11:21:06 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D0828355; Thu, 18 Sep 2014 11:21:05 +0000 (UTC) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id s8IBL0wj002601 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 18 Sep 2014 14:21:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua s8IBL0wj002601 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id s8IBL08a002599; Thu, 18 Sep 2014 14:21:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 18 Sep 2014 14:21:00 +0300 From: Konstantin Belousov To: Edward Tomasz Napierala Subject: Re: svn commit: r271753 - head/sys/fs/autofs Message-ID: <20140918112100.GS2161@kib.kiev.ua> References: <201409181033.s8IAXNZ1054205@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IpljlC28XhFjURzf" Content-Disposition: inline In-Reply-To: <201409181033.s8IAXNZ1054205@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2014 11:21:06 -0000 --IpljlC28XhFjURzf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 18, 2014 at 10:33:23AM +0000, Edward Tomasz Napierala wrote: > Author: trasz > Date: Thu Sep 18 10:33:23 2014 > New Revision: 271753 > URL: http://svnweb.freebsd.org/changeset/base/271753 >=20 > Log: > Fix typos. > =20 > Sponsored by: The FreeBSD Foundation >=20 > Modified: > head/sys/fs/autofs/autofs.c >=20 > Modified: head/sys/fs/autofs/autofs.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/fs/autofs/autofs.c Thu Sep 18 10:01:56 2014 (r271752) > +++ head/sys/fs/autofs/autofs.c Thu Sep 18 10:33:23 2014 (r271753) > @@ -430,7 +430,7 @@ autofs_trigger_one(struct autofs_node *a > autofs_restore_sigmask(&oldset); > if (error !=3D 0) { > /* > - * XXX: For some reson this returns -1 > + * XXX: For some reason this returns -1 > * instead of EINTR, wtf?! > */ > error =3D EINTR; > @@ -542,7 +542,7 @@ autofs_ioctl_request(struct autofs_daemo > &autofs_softc->sc_lock); > if (error !=3D 0) { > /* > - * XXX: For some reson this returns -1 instead > + * XXX: For some reason this returns -1 instead > * of EINTR, wtf?! > */ > error =3D EINTR; The -1 is ERESTART, i.e. it is correct error value which indicates that syscall return path must restart the syscall after the trip to userland. This behaviour is controlled by SA_RESTART flag, see sigaction(2). There are some syscalls, which explicitely deny restarting, mostly to correctly handle timeout values, most prominent is select(2) family. The comment above is definitely inappropriate, and translation of ERESTART to EINTR may be wrong as well. --IpljlC28XhFjURzf Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUGsAcAAoJEJDCuSvBvK1BJZcP/1V0BdWox5Ac+PEPNSEu8pnX GV+7+rhPPzadarXWf3qF0AM8wJFEwbbFZA4CvqQ1meSmCIdXVatYpcn0t5gQBtQI cbOCJOzwhkCEFw2DgFEVh8gusFqEUZiNOLeFXa8d5ERtZboUX2OHIo5ewflgmEDq St/piJda4DzE6v+9vm3ctI9iBf1IcIok9+UzNwtk6+fI1ZdurVmNDw6rLqNha3fD kThy+SZNLzB83qJMJDiO57uiMRDeKaOxFSQD7bqy3gg9nk+fucAGC1LONIe6Z/QJ G/H71cBE+e8JBvA21wKSb/RY9f3B59ErnZYOva0Hey5fnBqcEs8BrYTlwdgfcKJE Cjn1aSCqlW5VcmkRn0m3qgyb0eMoIGCtTkpeM02D+TKfq+R2fuxnqJd4hcqBrwS1 D4Q4AXDktBsjbVZQIdL4YE0sj1F1h3k3hsBRSFWsEuPvZAaIGVG1mos1iULh6+3G kxzV0OzY/ANuAsLkWwcELa5qrWwvIAUJMHBBw7GCBGDo95Egw0ij2lY5E1ABGyad NaWIYfdMkVRQqIJ/lFxZhkbW9kM+qBD6woOTPUDzB8a3zLF30lmEZaqYlpHI24T5 SK/juzM3id4FdjpnOpPGnZwNSiD6HmKloq9Ako4TYDkEgQQ+GOCngA5odcLfmurB j9pmQImjJ9Ud1HiDGzo/ =Oi6+ -----END PGP SIGNATURE----- --IpljlC28XhFjURzf--