Date: Thu, 3 Jan 2013 18:50:10 -0500 From: Glen Barber <gjb@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r309908 - head/textproc/docproj Message-ID: <20130103235010.GA16713@glenbarber.us> In-Reply-To: <20130104.084154.34484659539126409.hrs@allbsd.org> References: <201301032304.r03N40Mp002548@svn.freebsd.org> <20130104.084154.34484659539126409.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 04, 2013 at 08:41:54AM +0900, Hiroki Sato wrote: > gj> Log: > gj> Unset WITH_JADETEX if not otherwise specified. > gj> > [...] >=20 > Please revert this and convert it to OPTIONS_DEFINE instead. Converting this entire port to OPTIONSng has been on my todo list for a few months now, but IMHO, this port overall is very messy. > WITH_JADETEX=3Dno by default makes explanations in files/JADETEX > useless and is counterintuitive because a docproj package for > releases has been built with WITH_JADETEX=3Dyes for a long time. Some > more clean-ups are needed for consistency, but simply setting "no" by > default is still problematic and solves nothing IMO. Is WITH_JADETEX=3Dyes for release builds set in non-public build scripts? All the release build scripts for head/, stable/9/, and stable/8/ set WITH_JADETEX=3Dno. In that case, I see no immediate chance for regression, and nonintuitive behavior within the port itself is prevented. In any case, if reverting it is still necessary, I will do so. Glen --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQEcBAEBCAAGBQJQ5hkyAAoJEFJPDDeguUajhfQH/iGygdqeRsc9CimI5X20ODz3 p2kmr4/2Ax5uB8B7VfmixdsbAEEaXsYIZUXhAM4lghgcDalfyFjB0CDqlSnkSmog E+CNI0U9SV54c9Ki4Rud1s+/r2dFHAKzJBMhnRpuf1KIAP2PDSPQl/BXmjOJ/Qhe DXDSjfRaCsZhoCtD5sI9eaaMqytBX3OFr1YJ5A3ElWEIWkbb5wjBRXsqNB2cTj18 vnlpzxemeTRwyZDW5/RUihx2y3SfFVfKjlJeO88WUYV1GVnkO/86VPNjbGR7DC50 IwIJJlqyyKu5rWsMjCNnScQigvzaxmm+Ss3APZr5Mmp2Yv8UalWYmejmPRVV8kE= =/Eay -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130103235010.GA16713>