Date: Thu, 01 Dec 2016 09:36:22 -0700 From: Ian Lepore <ian@freebsd.org> To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309350 - head/etc Message-ID: <1480610182.1889.192.camel@freebsd.org> In-Reply-To: <201612010435.uB14Zfgu020006@repo.freebsd.org> References: <201612010435.uB14Zfgu020006@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 2016-12-01 at 04:35 +0000, Warner Losh wrote: > Author: imp > Date: Thu Dec 1 04:35:41 2016 > New Revision: 309350 > URL: https://svnweb.freebsd.org/changeset/base/309350 > > Log: > If the kenv variable rc_debug is set, turn on rc_debug. > > Modified: > head/etc/rc.subr > > Modified: head/etc/rc.subr > ===================================================================== > ========= > --- head/etc/rc.subr Thu Dec 1 04:35:38 2016 (r309349) > +++ head/etc/rc.subr Thu Dec 1 04:35:41 2016 (r309350) > @@ -2119,6 +2119,12 @@ _echoonce() > esac > } > > +# If the loader env variable rc.debug is set, turn on debugging. > rc.conf will > +# still override this, but /etc/defaults/rc.conf.a > +if kenv -q rc.debug > /dev/null ; then > + rc_debug=YES > +fi > + > fi # [ -z "${_rc_subr_loaded}" ] > > _rc_subr_loaded=: > The commit message says rc_debug but the env var in your code is rc.debug. I think rc_debug would be better -- easier than remembering two different names for the same functionality. BTW, thanks for this, it's a great idea. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1480610182.1889.192.camel>