From owner-svn-src-head@freebsd.org  Thu Dec  1 16:36:36 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id ACE8BC60F67
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Thu,  1 Dec 2016 16:36:36 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org
 [52.58.109.202])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 509B41EC8
 for <svn-src-head@freebsd.org>; Thu,  1 Dec 2016 16:36:35 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 4e1c8f3f-b7e4-11e6-9673-39b5816e8152
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 73.78.92.27
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [73.78.92.27])
 by outbound1.eu.mailhop.org (Halon) with ESMTPSA
 id 4e1c8f3f-b7e4-11e6-9673-39b5816e8152;
 Thu, 01 Dec 2016 16:36:28 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id uB1GaMNu003826;
 Thu, 1 Dec 2016 09:36:22 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <1480610182.1889.192.camel@freebsd.org>
Subject: Re: svn commit: r309350 - head/etc
From: Ian Lepore <ian@freebsd.org>
To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Date: Thu, 01 Dec 2016 09:36:22 -0700
In-Reply-To: <201612010435.uB14Zfgu020006@repo.freebsd.org>
References: <201612010435.uB14Zfgu020006@repo.freebsd.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Dec 2016 16:36:36 -0000

On Thu, 2016-12-01 at 04:35 +0000, Warner Losh wrote:
> Author: imp
> Date: Thu Dec  1 04:35:41 2016
> New Revision: 309350
> URL: https://svnweb.freebsd.org/changeset/base/309350
> 
> Log:
>   If the kenv variable rc_debug is set, turn on rc_debug.
> 
> Modified:
>   head/etc/rc.subr
> 
> Modified: head/etc/rc.subr
> =====================================================================
> =========
> --- head/etc/rc.subr	Thu Dec  1 04:35:38 2016	(r309349)
> +++ head/etc/rc.subr	Thu Dec  1 04:35:41 2016	(r309350)
> @@ -2119,6 +2119,12 @@ _echoonce()
>  	esac
>  }
>  
> +# If the loader env variable rc.debug is set, turn on debugging.
> rc.conf will
> +# still override this, but /etc/defaults/rc.conf.a
> +if kenv -q rc.debug > /dev/null ; then
> +	rc_debug=YES
> +fi
> +
>  fi # [ -z "${_rc_subr_loaded}" ]
>  
>  _rc_subr_loaded=:
> 

The commit message says rc_debug but the env var in your code is
rc.debug.  I think rc_debug would be better -- easier than remembering
two different names for the same functionality.

BTW, thanks for this, it's a great idea.

-- Ian