From owner-freebsd-current@FreeBSD.ORG Wed Jul 15 14:01:25 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7F75106566C; Wed, 15 Jul 2009 14:01:25 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 9AD008FC08; Wed, 15 Jul 2009 14:01:25 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 510CE46B82; Wed, 15 Jul 2009 10:01:25 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id C399A8A09B; Wed, 15 Jul 2009 10:01:23 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Date: Wed, 15 Jul 2009 08:41:56 -0400 User-Agent: KMail/1.9.7 References: <20090715104934.GA58659@freebsd.org> In-Reply-To: <20090715104934.GA58659@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200907150841.56605.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 15 Jul 2009 10:01:24 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Roman Divacky , current@freebsd.org Subject: Re: ppc(4) locking of isa_dma* X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jul 2009 14:01:26 -0000 On Wednesday 15 July 2009 6:49:35 am Roman Divacky wrote: > hi > > the isa_dma* functions seem to require Giant. ppc(4) uses those > but does not seem to lock Giant or anything. is this ok? > is it a bug? Doh, that is a bug. > I looked at the i386/isa/isa_dma.c and it seems pretty selfcontained > (ie. it operates on hw and it's own variables). would it be sufficient > to just introduce a new lock and lock with it all the isa_dma* functions > ? or is there some indirect dependency on Giant that I cant see? That would probably work. If it can be self-contained in the isa_dma API that would so that consumers do not need fixing that would be ideal. -- John Baldwin