Date: Sun, 31 Aug 2014 09:10:25 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 193196] New: [patch][stage][new-maintainer] amanda-server and amanda-client: Stage support and take maintainership Message-ID: <bug-193196-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193196 Bug ID: 193196 Summary: [patch][stage][new-maintainer] amanda-server and amanda-client: Stage support and take maintainership Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: freebsd-ports-bugs@FreeBSD.org Reporter: fbsd@dylanleigh.net Created attachment 146586 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=146586&action=edit Imperfect patch to add staging support and new maintaner for amanda-server/amanda-client The attached patch adds stage support to amanda-server (and amanda-client, which is a slave port of amanda-server). It also sets me as the maintainer (was unmaintained). It builds and runs OK on my 9-STABLE AMD64 fileserver, but there are some possible stage-related issues: 1) Amanda (upstream code) builds its own install-hook target which it uses to set setuid bits amongst other things, This isn't ideal and prevents packages being built as non-root amongst other things. I have tried to fix this but haven't had the time yet to figure it out so I have set NEEDS_ROOT in the Makefile for now. 2) Many reported orphans were added to the plist after several iterations of the patch, and I am not sure if I have set everything correctly so that files which will only be present given certain OPTIONS are set correctly in the plist and vice versa. Some of the reported orphans from make check-orphans seem to be false positives caused by the way the port splits up building the client and server. This is my first staging patch, so I expect errors. Please let me know if there is anything missing. -- Dylan -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193196-13>