From owner-svn-src-head@FreeBSD.ORG Tue Aug 13 20:40:13 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 68091854; Tue, 13 Aug 2013 20:40:13 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 229D923C1; Tue, 13 Aug 2013 20:40:11 +0000 (UTC) Received: from alph.d.allbsd.org (p2049-ipbf1102funabasi.chiba.ocn.ne.jp [122.26.101.49]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r7DKdsbC089882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 14 Aug 2013 05:40:04 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.5/8.14.5) with ESMTP id r7DKdqQ7018805; Wed, 14 Aug 2013 05:39:54 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Wed, 14 Aug 2013 05:35:54 +0900 (JST) Message-Id: <20130814.053554.1333869805065914360.hrs@allbsd.org> To: gjb@FreeBSD.org Subject: Re: svn commit: r254224 - head/share/man/man7 From: Hiroki Sato In-Reply-To: <20130813195257.GA2241@glenbarber.us> References: <201308111857.r7BIvRSq080970@svn.freebsd.org> <20130814.042557.877689080765344354.hrs@allbsd.org> <20130813195257.GA2241@glenbarber.us> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Wed_Aug_14_05_35_54_2013_192)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Wed, 14 Aug 2013 05:40:04 +0900 (JST) X-Spam-Status: No, score=-90.6 required=13.0 tests=CONTENT_TYPE_PRESENT, DIRECTOCNDYN,DYN_PBL,RCVD_IN_PBL,SPF_SOFTFAIL,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Aug 2013 20:40:13 -0000 ----Security_Multipart(Wed_Aug_14_05_35_54_2013_192)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Glen Barber wrote in <20130813195257.GA2241@glenbarber.us>: gj> On Wed, Aug 14, 2013 at 04:25:57AM +0900, Hiroki Sato wrote: gj> > gj> +.It Va SRCREVISION gj> > gj> +The revision of the gj> > gj> +.Li src/ gj> > gj> +tree to use. gj> > gj> +Defaults to the current top of tree revision. gj> > gj> +.It Va DOCREVISION gj> > gj> +The revision of the gj> > gj> +.Li doc/ gj> > gj> +tree to use. gj> > gj> +Defaults to the current top of tree revision. gj> > gj> +.It Va PORTREVISION gj> > gj> > Why separation between revision and branch is needed? I gj> > intentionally dropped this part from your old patch to gj> > generate-release.sh because branch and revision number can be gj> > specified like releng/9.2@NNN in a single variable. An incorrect gj> > configuration of the two variables do not always cause a fatal error, gj> > so specification in fewer number of variables is more foolproof. gj> > gj> gj> I personally do not like using branch@rNNNNNN, but will update to remove gj> the {SRC,DOC,PORT}REVISION variables. Thank you. I don't like it either, honestly... gj> > gj> +.It Va TARGET gj> > gj> +The target machine type for the release. gj> > gj> +Defaults to the current machine type. gj> > gj> +.It Va TARGET_ARCH gj> > gj> +The target machine architecture for the release. gj> > gj> +Defaults to the value of gj> > gj> +.Va TARGET . gj> > gj> +.Pp gj> > gj> > Please remove default configuration of these variables from gj> > release.sh. The reasonable defaults are already set in src/Makefile gj> > and setting TARGET_ARCH=$TARGET by default is simply wrong. Also, gj> > get_rev_branch() is redundant. gj> > gj> gj> Will be changed shortly. gj> gj> Why is get_rev_branch() redundant? Because variables in get_rev_branch() are already defined in src/release/Makefile, too. If one wants to use them in release.sh for some reason, "make -VBRANCH" is preferable instead of duplicating the same logic in Makefile to extract them from newvers.sh. This script should not do the same job which Makefile does. IMO, the default value of OSRELEASE is not needed here. It seems used in RELSTRING, but it does not work (and even if it works, it just generates the same default value). If we always need to override the default value, Makefile should be fixed instead. -- Hiroki ----Security_Multipart(Wed_Aug_14_05_35_54_2013_192)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlIKmKoACgkQTyzT2CeTzy3K3ACg0ggV0UJjWdkMB8//wZMOLnMo i18AnA+E0Au/N175GwCp+WMHWn7KAAD9 =gWnC -----END PGP SIGNATURE----- ----Security_Multipart(Wed_Aug_14_05_35_54_2013_192)----