From owner-svn-src-head@freebsd.org Fri Aug 25 15:47:33 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90E77DDB61F for ; Fri, 25 Aug 2017 15:47:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22b.google.com (mail-it0-x22b.google.com [IPv6:2607:f8b0:4001:c0b::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 54C386559C for ; Fri, 25 Aug 2017 15:47:33 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22b.google.com with SMTP id n5so1010887itb.1 for ; Fri, 25 Aug 2017 08:47:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9sEQRn4N+eOQd3gz3T21FtdfVQriECvlprpkX+P8Sno=; b=Zh9I2tpTLeDed4UU6aPy8lE36DanywADnEwwD19g7cp0Bx6uuQhExrBf1qlqZdNvF5 8nxac469LNg0qyvhy45eUpfdgAFxINui3NWkbWFpLNVM1S5y3rVGSUj5POdoplFPJdfV uTDEyhTWcMSgQ/VOlQsWIANn1N81EMoP6yOGS1C3e2/vBl7L1k997rhnw6gFivIM4SUK FeHAXXErpa174AbPpt2c55pU5o8epwQc1pVJezR3Ngl2Wf/n0Q8aeA+3gCqOq7rm0Opb f8HmzwN5UNqggw4hfRUmWwaz+/JiTkkZdhuvSX8U8sxog+DDNneTNBD7zK+8mauR98Z0 shKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9sEQRn4N+eOQd3gz3T21FtdfVQriECvlprpkX+P8Sno=; b=Wc+GvIfg3OpMwdknvyvddHOzNwiUT9HGiToCSGXSoj4WrLGkWxzLrPhazkACwZlcDq SOQ4JLI/wWOd/YnCyTELVoqXtgosCb0aCaJvIrGz28LPBYWG8if7lesg+SGhYVVIND0D Qohyvf1IonlV9grvxPbNVrqhanNj9u2a8Lw4SqV0SxLQrK578PU8PRsyB1YxznfU/sGa 6erVboAHARZuWiOsxy/hKBJ1fx599e1ifryuV6JZZjBAnumcs/CUbeC+dqv7U3ZFr3J5 ELQ4PLEI/xRGcArgfYoOq0BWs0BoTLwBGIMUL10HIIdDuZffC/7IlUYzBssQRQRpGkbr +VVA== X-Gm-Message-State: AHYfb5hc64tCkUdQgedzOAp/luErHOQHAPYqjqTmyxdSZ4ElHPphPDyT hWThXITkwGYt6IlLMDBLhn9aaE/jPZ0P X-Received: by 10.36.159.194 with SMTP id c185mr2254656ite.31.1503676052791; Fri, 25 Aug 2017 08:47:32 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.10.71 with HTTP; Fri, 25 Aug 2017 08:47:32 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:c525:dd46:ae7:666a] In-Reply-To: <20170825154626.GK9097@zxy.spb.ru> References: <201708242211.v7OMBAlc012582@repo.freebsd.org> <20170825133514.GA9110@zxy.spb.ru> <20170825154626.GK9097@zxy.spb.ru> From: Warner Losh Date: Fri, 25 Aug 2017 09:47:32 -0600 X-Google-Sender-Auth: 4W4H6abTuAG0NMtFhlTydC54P9o Message-ID: Subject: Re: svn commit: r322863 - head/sys/cam To: Slawa Olhovchenkov Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Aug 2017 15:47:33 -0000 On Fri, Aug 25, 2017 at 9:46 AM, Slawa Olhovchenkov wrote: > On Fri, Aug 25, 2017 at 09:33:35AM -0600, Warner Losh wrote: > > > On Fri, Aug 25, 2017 at 7:35 AM, Slawa Olhovchenkov > wrote: > > > > > On Thu, Aug 24, 2017 at 10:11:10PM +0000, Warner Losh wrote: > > > > > > > Author: imp > > > > Date: Thu Aug 24 22:11:10 2017 > > > > New Revision: 322863 > > > > URL: https://svnweb.freebsd.org/changeset/base/322863 > > > > > > > > Log: > > > > Expand the latency tracking array from 1.024s to 8.192s to help > track > > > > extreme outliers from dodgy drives. Adjust comments to reflect > this, > > > > and make sure that the number of latency buckets match in the two > > > > places where it matters. > > > > > > May be up to 1min? > > > > > > > I'm not sure what additional data you'll get between "totally sucks, at > > least 8s latency" and "totally sucks, at least 32s." or "totally sucks, > at > > least 64s" though the latter isn't possible with the default timeouts... > > > > I'm planning on adding a 'max' latency that's self-resetting instead of > > expanding the bucket upwards. I'm also contemplating expanding it down to > > 100us or even 10us since nda serves nvme drives which easily can be sub > > 100us. > > This is just stat data? > Don't produce error messages about timeout commands and etc? > This is 100% stats. There's no error messages produced. Warner