From owner-freebsd-current Mon Apr 3 14:28:26 1995 Return-Path: current-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id OAA19765 for current-outgoing; Mon, 3 Apr 1995 14:28:26 -0700 Received: from grunt.grondar.za (grunt.grondar.za [196.7.18.129]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id OAA19744; Mon, 3 Apr 1995 14:28:00 -0700 Received: from localhost (localhost [127.0.0.1]) by grunt.grondar.za (8.6.11/8.6.9) with SMTP id XAA05114; Mon, 3 Apr 1995 23:27:27 +0200 Message-Id: <199504032127.XAA05114@grunt.grondar.za> X-Authentication-Warning: grunt.grondar.za: Host localhost didn't use HELO protocol To: current@FreeBSD.org, bugs@FreeBSD.org Subject: Funnies in the SCSI kernel code... Date: Mon, 03 Apr 1995 23:27:26 +0200 From: Mark Murray Sender: current-owner@FreeBSD.org Precedence: bulk Hi What is going on here? [Next line is line 56 of /sys/scsi/sd.c] > #define SECSIZE 512 > #define SDOUTSTANDING 4 > #define SD_RETRIES 4 > #define MAXTRANSFER 8 /* 1 page at a time */ > > #define SDUNITSHIFT 3 > #define SDUNIT(DEV) SH3_UNIT(DEV) +++++ > #define SDSETUNIT(DEV, U) SH3SETUNIT((DEV), (U)) ===== > #define PARTITION(dev) dkpart(dev) > #define SDUNIT(dev) dkunit(dev) +++++ > > /* XXX introduce a dkmodunit() macro for this. */ > #define SDSETUNIT(DEV, U) \ ===== > makedev(major(DEV), dkmakeminor((U), dkslice(DEV), dkpart(DEV))) +++++ Multiple definition of SDUNIT ===== Multiple definition of SDSETUNIT If they were the same, frankly I wouldn't give a damn. What gives? M M -- Mark Murray 46 Harvey Rd, Claremont, Cape Town 7700, South Africa +27 21 61-3768 GMT+0200