From owner-freebsd-java@freebsd.org Sun Mar 24 06:53:23 2019 Return-Path: Delivered-To: freebsd-java@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BDF68154D6E2 for ; Sun, 24 Mar 2019 06:53:23 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (gerbercreations.com [71.39.140.16]) by mx1.freebsd.org (Postfix) with ESMTP id C22AC6F665 for ; Sun, 24 Mar 2019 06:53:22 +0000 (UTC) (envelope-from glewis@eyesbeyond.com) Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.15.2/8.15.2) with ESMTP id x2O6rKNJ054841; Sat, 23 Mar 2019 23:53:21 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.15.2/8.15.2/Submit) id x2O6rJrV054838; Sat, 23 Mar 2019 23:53:19 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Sat, 23 Mar 2019 23:53:19 -0700 From: Greg Lewis To: Michael Osipov <1983-01-06@gmx.net> Cc: freebsd-java@freebsd.org Subject: Re: openjdk11: include location changed Message-ID: <20190324065319.GB53471@misty.eyesbeyond.com> References: <16376136-18d2-f69a-9f4f-fbea5ca3b781@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <16376136-18d2-f69a-9f4f-fbea5ca3b781@gmx.net> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: C22AC6F665 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [0.86 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.12)[-0.116,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; DMARC_NA(0.00)[eyesbeyond.com]; AUTH_NA(1.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[cached: mail.iagu.net]; RCPT_COUNT_TWO(0.00)[2]; NEURAL_SPAM_LONG(0.35)[0.352,0]; NEURAL_HAM_SHORT(-0.35)[-0.348,0]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmx.net]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:209, ipnet:71.32.0.0/13, country:US]; IP_SCORE(-0.02)[asn: 209(-0.02), country: US(-0.07)] X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Mar 2019 06:53:24 -0000 On Sat, Mar 23, 2019 at 07:44:37PM +0100, Michael Osipov wrote: > Folks, > > I continued to test the new port against other projects and failed to > compile jansi-native which is used in Maven. The subtile difference is: > > > [mosipov@mika-ion /usr/ports/java/openjdk8]$ tree /usr/local/openjdk8/include/ > > /usr/local/openjdk8/include/ > > ├── classfile_constants.h > > ├── freebsd > > │   ├── jawt_md.h > > │   └── jni_md.h > > ├── jawt.h > > ├── jdwpTransport.h > > ├── jni.h > > ├── jvmti.h > > └── jvmticmlr.h > > > [mosipov@mika-ion /usr/ports/java/openjdk8]$ tree /usr/local/openjdk11/include/ > > /usr/local/openjdk11/include/ > > ├── bsd > > │   ├── jawt_md.h > > │   └── jni_md.h > > ├── classfile_constants.h > > ├── jawt.h > > ├── jdwpTransport.h > > ├── jni.h > > ├── jvmti.h > > └── jvmticmlr.h > > > freesbd vs bsd > > in ports I see: > > [mosipov@mika-ion /usr/ports/java/openjdk8]$ find . -name jni_md.h > > ./work/openjdk/jdk/src/macosx/javavm/export/jni_md.h > > ./work/openjdk/jdk/src/windows/javavm/export/jni_md.h > > ./work/openjdk/jdk/src/solaris/javavm/export/jni_md.h > > ./work/openjdk/hotspot/src/share/vm/prims/jni_md.h > > > [mosipov@mika-ion /usr/ports/java/openjdk11]$ find . -name jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/src/java.base/unix/native/include/jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/src/java.base/windows/native/include/jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/build/bsd-x86-normal-server-release/support/modules_include/java.base/bsd/jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/build/bsd-x86-normal-server-release/support/interim-image/include/bsd/jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/build/bsd-x86-normal-server-release/jdk/include/bsd/jni_md.h > > ./work/openjdk-jdk11u-jdk-11.0.2-9-2/build/bsd-x86-normal-server-release/images/jdk/include/bsd/jni_md.h > > Is that change on purpose? > > Shall I open an issue with Jansi Native? This is an issue with the JDK, that change was not on purpose. In general most software will expect the directory to be freebsd rather than bsd and we should fix that. Can you please open a PR regarding this? -- Greg