From owner-freebsd-fs@FreeBSD.ORG Tue Jan 27 13:40:05 2004 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9460216A4CE; Tue, 27 Jan 2004 13:40:05 -0800 (PST) Received: from smtp.omnis.com (smtp.omnis.com [216.239.128.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id AC3B243D73; Tue, 27 Jan 2004 13:39:37 -0800 (PST) (envelope-from wes@softweyr.com) Received: from salty.rapid.stbernard.com (corp-2.ipinc.com [199.245.188.2]) by smtp-relay.omnis.com (Postfix) with ESMTP id C0BA58836C0; Tue, 27 Jan 2004 13:37:56 -0800 (PST) From: Wes Peters Organization: Softweyr.com To: Xin LI , FreeBSD-gnats-submit@freebsd.org Date: Tue, 27 Jan 2004 13:37:30 -0800 User-Agent: KMail/1.5.4 References: <20040127065331.43F7611AE7@beastie.frontfree.net> In-Reply-To: <20040127065331.43F7611AE7@beastie.frontfree.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200401271337.30976.wes@softweyr.com> X-Mailman-Approved-At: Wed, 28 Jan 2004 06:15:23 -0800 cc: mckusick@FreeBSD.org Subject: Re: [PATCH] bring incompletely initialized magic to UFS1 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2004 21:40:05 -0000 On Monday 26 January 2004 22:53, Xin LI wrote: > >Submitter-Id: current-users > >Originator: Xin LI > >Organization: The FreeBSD Simplified Chinese Project > >Confidential: no > >Synopsis: [PATCH] bring incompletely initialized magic to UFS1 > >Severity: non-critical > >Priority: low > >Category: bin > >Class: change-request > >Release: FreeBSD 5.2-RELEASE i386 > >Environment: > > System: FreeBSD beastie.frontfree.net 5.2-RELEASE FreeBSD 5.2-RELEASE > #16: Sat Jan 10 15:24:09 CST 2004 > delphij@beastie.frontfree.net:/usr/obj/usr/src/sys/BEASTIE i386 > > >Description: > > The attached is a proposal patch to make it possible to mark UFS1 as > "incompletely initialized" when newfs(8) did not have it actually > initialized. To implement this, I have borrowed the "bad UFS2" magic > number. Please review this patch. Frankly I am not sure if this is > useful in most circumstances, but a "incomplete" flag is really > useful for certain needs. I looks OK to me. I assume you've tested it extensively, correct? I'll see if I can locate an extra disk for testing and give this a try at home, then commit it as soon as I've verified it works OK. Thanks for the input. -- "Where am I, and what am I doing in this handbasket?" Wes Peters wes@softweyr.com