From owner-svn-src-head@freebsd.org  Fri Jul 14 02:33:18 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0B7D5DB3538;
 Fri, 14 Jul 2017 02:33:18 +0000 (UTC)
 (envelope-from rlibby@gmail.com)
Received: from mail-wr0-x232.google.com (mail-wr0-x232.google.com
 [IPv6:2a00:1450:400c:c0c::232])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 9950671E58;
 Fri, 14 Jul 2017 02:33:17 +0000 (UTC)
 (envelope-from rlibby@gmail.com)
Received: by mail-wr0-x232.google.com with SMTP id 48so262714wrz.0;
 Thu, 13 Jul 2017 19:33:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=BIGeHjLkb18461yMKujNDXufpPuaiBsA4qJJ2UjDKqA=;
 b=QXNzBqAbJLvIeV67pxzC9NUi/wOGjC3rivljjIuKPrOKs+CI28Hmq5+wK0m9SZdWmn
 AEPcTxrn6pwB/2m4x+HxOJSoSfoO36WsfzuEOoUlKAyLnS0/J+FipxVjldMYr7Vu4m4J
 8wJAtJ0TXelwQKDHj4ugECyDP878M40G7xVD0qsiLfCnzfCY7whXsk66o2mgfkRkUEWv
 VwiCw5W5zbAmG/5kDV72AAWDAFBFbYv9bV87WL5GuOZ2LVtpR9Td+sVei0Np6UQvRmwN
 6DaOibCO5KtHdffAoFgsAM1gnxNw9RGhbcDc7AX+zacmaC0vnl3r7xRzQYUjlHfgwgBf
 QDRw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=BIGeHjLkb18461yMKujNDXufpPuaiBsA4qJJ2UjDKqA=;
 b=CZyJh31q5UG1GP+YY16hy+KUVSGNnDL6KZ8UQt7QSh1C4OVOcLs5g5S7wQYaysEjP8
 QVTl1aRDjuuLl7oWDUMnKzRK00GUB22NRMHEdXPmkr8Lm6wZEzRSkvl6Q43lCddBpr+T
 2fon0C3QOi0FJ5qc34aXJYCoPdh89RMs/FiX5zcmg8+dZ1oH7Oh7xznsy6qkSGyQBmNt
 l/CsxHGU/zBUqp4b4Ck91iTmcAzmp4rCUr+7TZy/IHa4Igoln7RT//JAE96ph8E0gG54
 PxXk+PiR2b6CC3cR8Z5SDT/FmR3//I8LcOTFHZ6aLqJ3H9eM7HChClY1cf/z3j99Y4TV
 eKag==
X-Gm-Message-State: AIVw111KlvNTiU+wfDMfcpm/qXG7FYFVNxNqr+S1toeRHsI6BlkjAzV6
 uKpjsPIsr8S8eBM07o29oMEz035f5Nth
X-Received: by 10.223.129.163 with SMTP id 32mr3709014wra.185.1499999595604;
 Thu, 13 Jul 2017 19:33:15 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.223.161.81 with HTTP; Thu, 13 Jul 2017 19:33:14 -0700 (PDT)
In-Reply-To: <CAGHfRMAZBRqmk=xL_01F_Mkm2wgvjw2nYHv2vpKHVH07Q1FU5w@mail.gmail.com>
References: <201707140010.v6E0ApLQ052889@repo.freebsd.org>
 <CAGHfRMAZBRqmk=xL_01F_Mkm2wgvjw2nYHv2vpKHVH07Q1FU5w@mail.gmail.com>
From: Ryan Libby <rlibby@gmail.com>
Date: Thu, 13 Jul 2017 19:33:14 -0700
Message-ID: <CAHgpiFwD-opucqnfByBErhUswRDnx1Yoj0eODR7rGOzUfZHiQg@mail.gmail.com>
Subject: Re: svn commit: r320977 - head/sys/dev/ixl
To: Ngie Cooper <yaneurabeya@gmail.com>
Cc: Ryan Libby <rlibby@freebsd.org>, 
 "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>,
 Eric Joyner <erj@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Jul 2017 02:33:18 -0000

On Thu, Jul 13, 2017 at 6:17 PM, Ngie Cooper <yaneurabeya@gmail.com> wrote:
> On Thu, Jul 13, 2017 at 5:10 PM, Ryan Libby <rlibby@freebsd.org> wrote:
>> Author: rlibby
>> Date: Fri Jul 14 00:10:51 2017
>> New Revision: 320977
>> URL: https://svnweb.freebsd.org/changeset/base/320977
>
> ...
>
>> +const char * const ixl_fc_string[6] = {
>> +       "None",
>> +       "Rx",
>> +       "Tx",
>> +       "Full",
>> +       "Priority",
>> +       "Default"
>> +};
>
> This should use flexible arrays, e.g.,
>
> const char * const ixl_fc_string[] = {
>     "None",
>     ...
> };
>
> -Ngie

Since this is status quo and a style point, I think I will leave this
to erj's judgement.

Ryan