From owner-cvs-all Thu Dec 7 14:38:25 2000 From owner-cvs-all@FreeBSD.ORG Thu Dec 7 14:38:22 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26]) by hub.freebsd.org (Postfix) with ESMTP id 6955737B400; Thu, 7 Dec 2000 14:38:22 -0800 (PST) Received: from curve.dellroad.org (curve.dellroad.org [10.1.1.30]) by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id OAA75360; Thu, 7 Dec 2000 14:38:20 -0800 (PST) Received: (from archie@localhost) by curve.dellroad.org (8.11.0/8.11.0) id eB7McKF21304; Thu, 7 Dec 2000 14:38:20 -0800 (PST) (envelope-from archie) From: Archie Cobbs Message-Id: <200012072238.eB7McKF21304@curve.dellroad.org> Subject: Re: cvs commit: src/sys/dev/ichsmb ichsmb.c ichsmb_var.h In-Reply-To: "from John Baldwin at Dec 7, 2000 10:50:13 am" To: John Baldwin Date: Thu, 7 Dec 2000 14:38:20 -0800 (PST) Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL82 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG John Baldwin writes: > Looks ok at first glance. :) Was splhigh() protecting anything other than the > ichsmb softc? Nope.. > Also, which SMBus methods are you referring to in this comment? > > + * > + * This driver assumes that the generic SMBus code will ensure that > + * at most one process at a time calls into the SMBus methods below. Those defined in /sys/dev/smbus/smbus_if.m. See /sys/dev/smbus/smb.c. -Archie __________________________________________________________________________ Archie Cobbs * Packet Design * http://www.packetdesign.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message