Date: Sun, 1 Feb 2009 11:26:37 -0800 From: Andrew Thompson <thompsa@FreeBSD.org> To: Hans Petter Selasky <hselasky@c2i.net> Cc: freebsd-usb@freebsd.org Subject: Re: USB2 patches Message-ID: <20090201192637.GG32503@citylink.fud.org.nz> In-Reply-To: <200902011922.16810.hselasky@c2i.net> References: <20090131231957.GB31825@citylink.fud.org.nz> <200902011220.18745.hselasky@c2i.net> <20090201175021.GA32503@citylink.fud.org.nz> <200902011922.16810.hselasky@c2i.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 01, 2009 at 07:22:15PM +0100, Hans Petter Selasky wrote:
>
> If you compare the old USB code with the new USB code for if_zyd for example
> you see that there are dozens of error checks everywhere:
>
> if (error != 0)
> goto fail;
>
> In the new USB code I've factored out all those checks into 3 lines of code in
> every driver:
>
> if (usb2_config_td_is_gone(&sc->sc_config_td)) {
> goto error;
> }
>
> In your patch you remove all error checking! If the taskqueue system does not
> have an API function that can tell if the taskqueue is being drained from
> inside the taskqueue callback, the taskqueue system has to be modified! It
> cannot replace the existing system like it is now!
Things are still a work in progress, if I have missed some error
checking then it can be fixed up.
Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090201192637.GG32503>