From owner-cvs-all Sun Mar 10 12:29:47 2002 Delivered-To: cvs-all@freebsd.org Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by hub.freebsd.org (Postfix) with SMTP id 05D6E37B400; Sun, 10 Mar 2002 12:29:42 -0800 (PST) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 10 Mar 2002 20:29:41 +0000 (GMT) Date: Sun, 10 Mar 2002 20:29:40 +0000 From: David Malone To: Maxim Sobolev Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_linker.c Message-ID: <20020310202940.GA94559@walton.maths.tcd.ie> References: <200203101920.g2AJK1B38135@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200203101920.g2AJK1B38135@freefall.freebsd.org> User-Agent: Mutt/1.3.25i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Mar 10, 2002 at 11:20:01AM -0800, Maxim Sobolev wrote: > sobomax 2002/03/10 11:20:01 PST > > Modified files: > sys/kern kern_linker.c > Log: > Fix a breakage introduced in rev.1.75 (supposedly style cleanup), which results > in "missing dependencies" error when loading some kld modules. It is sad to > see how often these days style cleanus break doesn't broken things. Perhaps > people should recall good old principle: "don't fix it if it isn't broken". Maxim, Would you mind if I chaned all the "err = strcmp() if (err == 0)"s in this file into "if (strcmp() == 0)". The fix I proposed in the PR mentioned by Steven did this (it fixed the same bug and made the strcmps a little more sane). David. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message