From owner-freebsd-multimedia@FreeBSD.ORG Tue Jan 24 22:46:56 2012 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 38C57106564A; Tue, 24 Jan 2012 22:46:56 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-ee0-f54.google.com (mail-ee0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 9175C8FC13; Tue, 24 Jan 2012 22:46:55 +0000 (UTC) Received: by eekb47 with SMTP id b47so1917562eek.13 for ; Tue, 24 Jan 2012 14:46:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=ePDA7XU/bZX1iHWW/72HSWNPh6tw68GqCL+k1gpkmh8=; b=SCiCA/qGKOahIkCu4tJ7zxvXvr5tlgS3vxvPRdukTDGY8tPuD7/KI4PxybYJVCKFJv jnSRxF1Zc00bpKg6Lz/6xU2lY35nJ0VT35LSEVaTEOSH89dcyP88R4aUVBy24tV2nnFC wS1nmsa0BBM4SO9fIDUSIpqyZmzjHziKONVpw= Received: by 10.14.14.165 with SMTP id d37mr5266164eed.91.1327445214476; Tue, 24 Jan 2012 14:46:54 -0800 (PST) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua. [212.86.226.226]) by mx.google.com with ESMTPS id r2sm73415610eef.7.2012.01.24.14.46.52 (version=SSLv3 cipher=OTHER); Tue, 24 Jan 2012 14:46:53 -0800 (PST) Sender: Alexander Motin Message-ID: <4F1F34DB.9040405@FreeBSD.org> Date: Wed, 25 Jan 2012 00:46:51 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111227 Thunderbird/9.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?Micka=EBl_Maillot?= References: <4F0DE3FD.2020203@FreeBSD.org> <20120112121853.GC1429@procyon.xvoid.org> <4F0ED8D0.8080403@FreeBSD.org> <4F171D7A.4080003@FreeBSD.org> <4F177979.5010106@FreeBSD.org> <4F1ACBA8.6000203@FreeBSD.org> <4F1EB305.9000105@FreeBSD.org> <4F1EDD3D.6070800@FreeBSD.org> <4F1F31CA.5000507@FreeBSD.org> In-Reply-To: <4F1F31CA.5000507@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: freebsd-multimedia@freebsd.org, FreeBSD current Subject: Re: [RFT] Major snd_hda rewrite X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2012 22:46:56 -0000 On 01/25/12 00:33, Alexander Motin wrote: > On 01/25/12 00:13, Mickaël Maillot wrote: >> 2012/1/24 Alexander Motin > >> Here is it: http://people.freebsd.org/~__mav/hda.HBR.patch >> >> It should activate HBR mode if you try to play stream with AC3 >> format and 8 channels (>6Mbps). >> >> no change with the patch because when i SNDCTL_DSP_SETFMT to AFMT_AC3, >> SNDCTL_DSP_CHANNELS always return 2 channels even if i >> set SNDCTL_DSP_SPEED to 192000. >> and i think it's why "if ((ch->fmt & AFMT_AC3) && (cchn == 8))" can't be >> true. >> i checked my /v/l/messages and saw PCMDIR_PLAY ....chan_count=0x01. > > Number of channels should be set to 8 by application when it expects bit > rate above 6Mbps. Sample rate, as I've described, just give more fine > control. Increasing sample rate does not automatically increase > channels. They are orthogonal: > Rate 48 96 192 48 96 192 > Channels 2 2 2 8 8 8 > ---------------------------------------------------------- > Mbps 1.5 3 6 12 24 49 > > What I've forgot is to allow 8ch format. :) Add the patch below. Hope > sound(4) has no other limitations for it. Hmm. Looks like there is some limitation. You may grep kernel for AFMT_PASSTHROUGH and find two "XXX force ..." comments and code, including forcing 2 channels for AC3. Luckily for not part for frequency is commented out. Further we may try to comment or modify part about number of channels. > --- hdaa.c (revision 230511) > +++ hdaa.c (working copy) > @@ -4979,6 +4979,8 @@ > } > if (HDA_PARAM_SUPP_STREAM_FORMATS_AC3(fmtcap)) { > ch->fmtlist[i++] = SND_FORMAT(AFMT_AC3, 2, 0); > + if (channels >= 8) > + ch->fmtlist[i++] = SND_FORMAT(AFMT_AC3, 8, 0); > } > ch->fmtlist[i] = 0; > i = 0; > > But in your case I think it should be enough to just increase sample > rate to 96 or 192KHz. -- Alexander Motin