From owner-svn-src-all@freebsd.org Wed Jan 1 22:50:24 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 235A51E2D36; Wed, 1 Jan 2020 22:50:24 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47p5wc08qpz4TLZ; Wed, 1 Jan 2020 22:50:24 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 00B199AE5; Wed, 1 Jan 2020 22:50:24 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 001MoNEt053567; Wed, 1 Jan 2020 22:50:23 GMT (envelope-from mjg@FreeBSD.org) Received: (from mjg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 001MoNkF053566; Wed, 1 Jan 2020 22:50:23 GMT (envelope-from mjg@FreeBSD.org) Message-Id: <202001012250.001MoNkF053566@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mjg set sender to mjg@FreeBSD.org using -f From: Mateusz Guzik Date: Wed, 1 Jan 2020 22:50:23 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r356260 - head/sys/fs/msdosfs X-SVN-Group: head X-SVN-Commit-Author: mjg X-SVN-Commit-Paths: head/sys/fs/msdosfs X-SVN-Commit-Revision: 356260 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jan 2020 22:50:24 -0000 Author: mjg Date: Wed Jan 1 22:50:23 2020 New Revision: 356260 URL: https://svnweb.freebsd.org/changeset/base/356260 Log: msdos: vgone unconstructed vnode before vputing it Otherwise someone else may race to start using it. Race window was opened by r351748 ("vfs: implement usecount implying holdcnt"). Noted by: kib Modified: head/sys/fs/msdosfs/msdosfs_denode.c Modified: head/sys/fs/msdosfs/msdosfs_denode.c ============================================================================== --- head/sys/fs/msdosfs/msdosfs_denode.c Wed Jan 1 22:47:00 2020 (r356259) +++ head/sys/fs/msdosfs/msdosfs_denode.c Wed Jan 1 22:50:23 2020 (r356260) @@ -230,7 +230,7 @@ deget(struct msdosfsmount *pmp, u_long dirclust, u_lon * Arrange for vput() to just forget about it. */ ldep->de_Name[0] = SLOT_DELETED; - + vgone(nvp); vput(nvp); *depp = NULL; return (error);