From owner-cvs-src@FreeBSD.ORG Sat Jun 21 10:53:18 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4C80237B405; Sat, 21 Jun 2003 10:53:18 -0700 (PDT) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9395143F93; Sat, 21 Jun 2003 10:53:17 -0700 (PDT) (envelope-from sam@errno.com) Received: from melange (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.9) with ESMTP id h5LHrG7N076811 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sat, 21 Jun 2003 10:53:17 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <00e801c3381d$fe8fa660$52557f42@errno.com> From: "Sam Leffler" To: "Poul-Henning Kamp" References: <1197.1056217385@critter.freebsd.dk> Date: Sat, 21 Jun 2003 10:53:16 -0700 Organization: Errno Consulting MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4920.2300 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4920.2300 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm vm_mmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jun 2003 17:53:19 -0000 > If your complaint is about the use of do { ... break; ... break; } > while (0); then launch an campaign to have it banned in style 9. > > IMO it is superior to goto, and ever deepening if-else constructs. My complaint is about using break in this obfuscated way. I'm not usually one to tell people _how_ to program and I consider style a gudeline and not a contract. But I dislike this change and consider it the epitome of "code churn". My last $0.02... Sam