From owner-svn-src-head@FreeBSD.ORG Thu Nov 8 09:22:37 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0EE4D590; Thu, 8 Nov 2012 09:22:37 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id A99B28FC0C; Thu, 8 Nov 2012 09:22:36 +0000 (UTC) Received: by mail-pb0-f54.google.com with SMTP id wz17so266246pbc.13 for ; Thu, 08 Nov 2012 01:22:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=NNrCKLKDuV6rWM6Faa9/OoOSXMjA/2NDBMC+WH5KzkI=; b=lhxlKwbJKk+ztohZDUVqCi3p1P4XVEVyNgBsvC+ys7TwhZ3RGyFTGidk9teUbSwi2S xJupIVenUenkHcjb6fDG3VCwbP/RugcdrFoRavlzxyavl/qQPJwiW5/vHoqKUkef/a5/ JuHuA+DpHvTVAZxcGUKln5/B5kVeun959X0ldv1olyQ4McMr8LyP5QKNkuxdrXUmNOMZ KLIx5MWf5RGCOVttAGAigCr4riYE+RiUCxbNj1FcPfnOGP6sUIumEF8T++h2M/olwmv2 XQxvlzStHXoC5OrbeZHSWlfQQ/QDqDfi8IIyV+rCL87nRDt10pkKknD+/lPefKrzKk4k jxGw== Received: by 10.68.252.40 with SMTP id zp8mr22405385pbc.66.1352366556031; Thu, 08 Nov 2012 01:22:36 -0800 (PST) Received: from [192.168.1.33] (adsl-99-61-74-22.dsl.pltn13.sbcglobal.net. [99.61.74.22]) by mx.google.com with ESMTPS id pw2sm15649038pbb.59.2012.11.08.01.22.34 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 08 Nov 2012 01:22:35 -0800 (PST) Subject: Re: svn commit: r242029 - head/sys/kern Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Garrett Cooper In-Reply-To: <509B77C0.9060202@mu.org> Date: Thu, 8 Nov 2012 01:22:33 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201210250146.q9P1kLi8043704@svn.freebsd.org> <20121025080551.GG35915@deviant.kiev.zoral.com.ua> <201210250950.57161.jhb@freebsd.org> <509B501F.5050109@mu.org> <509B77C0.9060202@mu.org> To: Alfred Perlstein X-Mailer: Apple Mail (2.1283) Cc: src-committers@freebsd.org, Peter Wemm , John Baldwin , svn-src-all@freebsd.org, Alfred Perlstein , Konstantin Belousov , svn-src-head@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Nov 2012 09:22:37 -0000 On Nov 8, 2012, at 1:13 AM, Alfred Perlstein wrote: > Peter, >=20 > I agree. >=20 > It's certainly not perfect, however it's not nearly as bogus as what = was there previously. >=20 > I know "maxusers" is "wrong", however what it really means, if you = think about it, is "give me a scaling factor that is relative to = physical ram, BUT capped at some value so as to not exhaust KVA." Yes, I = grok that on certain architectures that mbufs clusters aren't pulled = from KVA, but, that seems much less important than how broken it is = currently.... >=20 > This fix is "good enough" for the general case, and a far greater = improvement than what was there previously which would make FreeBSD blow = chunks on any sort of 10gigE load. >=20 > I think what needs to happen here, is that the people requiring = perfection think about what mess it was prior and if they themselves do = not have time to make it 100% perfect, allowing someone to step in and = move something > a step in the right direction without overly complicating it. >=20 > What is there is crap, it's old, crufty and broken, it really is. It = needs to be fixed, it needs to be given a nice fat band-aid now, and = when someone interested in perfection comes along, then they can make it = even more awesome. >=20 > I am not saying that my fix is PERFECT or the be all and end all, = however it serves as a good step in the right direction on our tier 1 = platforms and is easily modifiable (just replace "VM_MAX_KERNEL_ADDRESS = - VM_MIN_KERNEL_ADDRESS" with some form of MD magic sauce.) Would you = like me to do that? Replace the hardline calculation with some constant = that each platform can configure? >=20 > I'm thinking this might suffice to make purists a bit more happy: >=20 > #if defined(i386) || defined(amd64) > #define MAX_KERNEL_ADDRESS_SPACE (VM_MAX_KERNEL_ADDRESS - = VM_MIN_KERNEL_ADDRESS) > #else > #define MAX_KERNEL_ADDRESS_SPACE (1024*1024*1024) Only 1GB for KVA on 64-bit platforms too...? > #endif >=20 > Given my algorithm this should result in pretty much the same for = other platforms than amd64 which will then be able to grow maxusers = some. >=20 > I'm basically running out of time on this and I'm worried that I'll = have to back it out indefinitely so that FreeBSD can't do 10gigE out of = the box. I agree with the philosophy being taken. Perfection shouldn't be the = enemy of the good as long as it gets close enough that things are more = useful than they are today. Thanks for championing this Alfred. The less voodoo required for FreeBSD = to function on commodity hardware, the better! -Garrett=