From owner-svn-src-all@freebsd.org Tue Apr 25 21:26:21 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11A2FD503EC; Tue, 25 Apr 2017 21:26:21 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CD12F135; Tue, 25 Apr 2017 21:26:20 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id E89F736F7; Tue, 25 Apr 2017 21:26:19 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id B533B79E9; Tue, 25 Apr 2017 21:26:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id 3WzPXhTwbSxH; Tue, 25 Apr 2017 21:26:15 +0000 (UTC) Subject: Re: svn commit: r317409 - head/contrib/tcpdump DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com F2B9279E4 To: Benjamin Kaduk , John Baldwin References: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> <9709200.gDHZIeQ1vL@ralph.baldwin.cx> Cc: rgrimes@freebsd.org, Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Tue, 25 Apr 2017 14:26:06 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WMlkGTGa6kleJW1gNWMJkCATnISu5dEml" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Apr 2017 21:26:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WMlkGTGa6kleJW1gNWMJkCATnISu5dEml Content-Type: multipart/mixed; boundary="8rSAfEUsWKNufUJ4lJdmaagpfJAejjWtX"; protected-headers="v1" From: Bryan Drewery To: Benjamin Kaduk , John Baldwin Cc: rgrimes@freebsd.org, Gleb Smirnoff , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Message-ID: Subject: Re: svn commit: r317409 - head/contrib/tcpdump References: <201704252010.v3PKA0ba063109@pdx.rh.CN85.dnsmgr.net> <9709200.gDHZIeQ1vL@ralph.baldwin.cx> In-Reply-To: --8rSAfEUsWKNufUJ4lJdmaagpfJAejjWtX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/25/2017 1:38 PM, Benjamin Kaduk wrote: > On Tue, Apr 25, 2017 at 3:28 PM, John Baldwin > wrote: >=20 >=20 > I do think that when referring to a Git hash the citation should > also include > something to identify which repository it came from. It doesn't > have to be a > URL per se (we just use 'NetBSD' for makefs, not a full URL to NetB= SD's > cvsweb), but it should be clear enough that one can find the > corresponding > repository. Probably that information belongs in 'Obtained From'. >=20 >=20 > Since Rodney asked and I already have the svn log up, here are some exi= sting > commits that are doing similar sorts of things: > r317267 is typical of the illumos/ZFS imports > though sometimes a full github URL is used, as in r316695 > r316665 pulls from Concurrency Kit (I think; CK was not expanded in the= > commit message :( ) > r315947 from libcxxrt > r315926 and a few previous revisions from dragonflybsd.git > r315745 from libcxxrt > r314435 again from CK >=20 > and we're not even out of 2017 yet. >=20 Plus if tcpdump were using SVN then we would refer to an SVN revision here. If it were using CVS then a CVS revision. Like this commit in FreeBSD: > -----------------------------------------------------------------------= - > r306349 | pfg | 2016-09-26 09:06:50 -0700 (Mon, 26 Sep 2016) | 7 lines > Changed paths: > M /head/lib/libc/db/hash/hash_page.c >=20 > hash(3): protect in-memory page when using cross-endianness. >=20 > When writing out pages in the "other endian" format, make a copy > instead of trashing the in-memory one. >=20 > Obtained from: NetBSD (CVS rev. 1.29) >=20 > -----------------------------------------------------------------------= - It is definitely more useful to note which repository and what VCS system the revision/hash/version refers to. But there's nothing inherently wrong about using a git hash. Github !=3D git. It is merely a= n interface to git and is not required to use any of the git repositories on it given another mirror or local checkout. If a project uses git as their official VCS then a git hash is the proper reference. --=20 Regards, Bryan Drewery --8rSAfEUsWKNufUJ4lJdmaagpfJAejjWtX-- --WMlkGTGa6kleJW1gNWMJkCATnISu5dEml Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJY/774AAoJEDXXcbtuRpfPqK8IAJa5cJknpC1utjzGN4oJbzU0 CRrKWxaP1Qujlu5yY1lYLmRn2X1k5poxQY6Pb5VeGx5H7b6eDJMnhLIx8mx8RMBe YFZ8oQ33Zh3ynsx6t5EXvaU8+oHOXS+xiHwgKVeHGsI75LQD/WEGgyKErRJjoK6D xuSdDZOAxEYekEoMr5mltZGkWqtj+dAPj9wyGZAFXrM1CmBKVbiOlWugZDbiXJOP fRw7tKr+2l0L6iWSzWcDjFIvOvKum2/VOj7zAwEhZha03JAS9+gzF0hRZ31tywLt odNLIw0trvG18Uxg/Qg4j7VdLzPLgMmDqP7HTeQX32qT4HwNa6W/3JEVBPgzVsM= =mFu4 -----END PGP SIGNATURE----- --WMlkGTGa6kleJW1gNWMJkCATnISu5dEml--