From owner-cvs-all Tue Jan 29 8:24:22 2002 Delivered-To: cvs-all@freebsd.org Received: from mail-green.research.att.com (H-135-207-30-103.research.att.com [135.207.30.103]) by hub.freebsd.org (Postfix) with ESMTP id B4CDD37B404; Tue, 29 Jan 2002 08:24:16 -0800 (PST) Received: from alliance.research.att.com (alliance.research.att.com [135.207.26.26]) by mail-green.research.att.com (Postfix) with ESMTP id 14E951E014; Tue, 29 Jan 2002 11:24:12 -0500 (EST) Received: from windsor.research.att.com (windsor.research.att.com [135.207.26.46]) by alliance.research.att.com (8.8.7/8.8.7) with ESMTP id LAA07757; Tue, 29 Jan 2002 11:24:10 -0500 (EST) From: Bill Fenner Received: (from fenner@localhost) by windsor.research.att.com (8.8.8+Sun/8.8.5) id IAA14538; Tue, 29 Jan 2002 08:24:10 -0800 (PST) Message-Id: <200201291624.IAA14538@windsor.research.att.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII To: trevor@jpj.net Subject: Re: cvs commit: ports/www/linux-netscape6 Makefile Cc: cvs-committers@freebsd.org, cvs-all@freebsd.org Date: Tue, 29 Jan 2002 08:24:10 -0800 Versions: dmail (solaris) 2.3/makemail 2.9b Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG >Your survey is a valuable resource for porters, and I didn't mean to >disrupt it. However, from looking at >http://people.freebsd.org/~fenner/portsurvey/www.html#linux-netscape6 I >get no clue about what I broke. Could you please explain in detail? >Otherwise, it's likely that I (or someone else) will cause a similar >problem in the future. The Makefile tries to cat a file that doesn't exist. These results only show up in my email and not on the web page, since usually any output possibly means a broken port. It wasn't disruptive to the port survey; sorry if the commit message implied that it was. >Whatever the trouble was, I have a feeling that your change might not >eliminate it. You added a test for the existence of components.conf, >which you do after the (interactive) configure script runs. No, the Makefile will try to read components.conf every time it is read, even in a freshly checked out ports directory. Try it -- do a "make distclean", then "make" and count the number of times that you see cat: /usr/ports/www/linux-netscape6/work//netscape-installer/xpi/components.conf: No such file or directory even before running the script. My patch simply avoided those errors. Bill To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message