From owner-svn-src-all@FreeBSD.ORG Tue Jul 29 21:10:10 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D038C3FE for ; Tue, 29 Jul 2014 21:10:10 +0000 (UTC) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com [209.85.215.41]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 555C225DA for ; Tue, 29 Jul 2014 21:10:10 +0000 (UTC) Received: by mail-la0-f41.google.com with SMTP id s18so198048lam.14 for ; Tue, 29 Jul 2014 14:10:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=bqkODvUJHRYURJJViPrHRH2vt/UcZdH7EPQ5fq8/pBs=; b=EYqHSFL/EnBEK7edp6P/UU6FpApg6gJ9TlZvrNGhAK11rrlcXrfJkKBEVrZxXipATh 8cUMvq9SGxTMr1MOj+QthPqN00viu2FnoTFRpmk3F/2H+eBq4wUCIHJMEcuE2EEo0Tc9 Sx5K5oXCEypbgSHoteg28sU6dxbnjZWIfi18E0qPYLSEaGsZnaxNGLeKLfMIYrLyxhlW YQmpm3CdA6kxAaRrm7SJ7dj4mi/om65obEvcgZIRcyj+nFc/OgMu+Ya4lMMzzq7hZ28l RVwyCQ5LieqR81kWKc/ACalSMOgIcjYQovh7dSvUBdxlC+V/Q9lYq2WqyRpVda41djFp aH6w== X-Gm-Message-State: ALoCoQmrxf0Wwo3ZJL7bjJmCkpFDwx94X62LshFFhMqg9wpC5iYC+8sd78Sm0a9KLe41/9s3PndZ X-Received: by 10.112.150.106 with SMTP id uh10mr4836944lbb.11.1406668202136; Tue, 29 Jul 2014 14:10:02 -0700 (PDT) Received: from raynote.ddteam.net (91-93-133-95.pool.ukrtel.net. [95.133.93.91]) by mx.google.com with ESMTPSA id la6sm72478lac.12.2014.07.29.14.10.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jul 2014 14:10:01 -0700 (PDT) Date: Wed, 30 Jul 2014 00:07:43 +0300 From: Aleksandr Rybalko To: Stefan Farfeleder Subject: Re: svn commit: r269188 - head/sys/dev/vt Message-Id: <20140730000743.1713fc43ec90a20c888e2511@ddteam.net> In-Reply-To: <20140728143722.GB1263@mole.fafoe.narf.at> References: <201407281422.s6SEMYuC087922@svn.freebsd.org> <20140728143722.GB1263@mole.fafoe.narf.at> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.22; amd64-portbld-freebsd11.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, Aleksandr Rybalko , src-committers@freebsd.org, svn-src-all@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jul 2014 21:10:10 -0000 On Mon, 28 Jul 2014 16:37:23 +0200 Stefan Farfeleder wrote: > On Mon, Jul 28, 2014 at 02:22:34PM +0000, Aleksandr Rybalko wrote: > > Author: ray > > Date: Mon Jul 28 14:22:34 2014 > > New Revision: 269188 > > URL: http://svnweb.freebsd.org/changeset/base/269188 > > > > Log: > > Avoid embedding buffers into static virtual terminal window. > > > > MFC after: 1 week > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > head/sys/dev/vt/vt_core.c > > > > Modified: head/sys/dev/vt/vt_core.c > > ============================================================================== > > --- head/sys/dev/vt/vt_core.c Mon Jul 28 14:20:31 2014 (r269187) > > +++ head/sys/dev/vt/vt_core.c Mon Jul 28 14:22:34 2014 (r269188) > > @@ -166,8 +166,8 @@ static struct vt_window vt_conswindow = > > .vw_number = VT_CONSWINDOW, > > .vw_flags = VWF_CONSOLE, > > .vw_buf = { > > - .vb_buffer = vt_constextbuf, > > - .vb_rows = vt_constextbufrows, > > + .vb_buffer = &vt_constextbuf[0], > > + .vb_rows = &vt_constextbufrows[0], > > .vb_history_size = VBF_DEFAULT_HISTORY_SIZE, > > .vb_curroffset = 0, > > .vb_roffset = 0, > > > > Hi Aleksandr, > > What's that supposed to change exactly? I'd be very surprised if it > didn't produce the same binary code. > > BR, > Stefan Hi Stefan! yeah, you a right, it's change nothing. I did wrong assumption, confuse with other things. But will left it. It looks better for me :) Thanks for review! WBW -- Aleksandr Rybalko