From owner-freebsd-arch@FreeBSD.ORG Wed Nov 7 21:17:44 2012 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9DC5879D; Wed, 7 Nov 2012 21:17:44 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 3F49A8FC0A; Wed, 7 Nov 2012 21:17:44 +0000 (UTC) Received: from outgoing.leidinger.net (p57A399A0.dip.t-dialin.net [87.163.153.160]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id E611984479F; Wed, 7 Nov 2012 22:17:31 +0100 (CET) Received: from unknown (IO.Leidinger.net [192.168.1.12]) by outgoing.leidinger.net (Postfix) with ESMTPS id 5EB102415; Wed, 7 Nov 2012 22:17:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=leidinger.net; s=outgoing-alex; t=1352323049; bh=cT6dTZtUxtuzkJGz8P5sNPWRCnmJZ3XBK6bRfvsCxMU=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=3IJVgwPSXoQfDmEhyeEErH1y+QQPcyNcCOcwdYxdTGCtDuRenMlWpH26D+YBGdp5d mnzlOQk63p7+s79ZIN+8lYyWo/lVkzVhzF2+L+FFK0M8DtfKMnRiuF7j05ex0ciKQh xjo2/6ITDqTf5POUkUV+bKkIVV+c8jKgDpFYZQw3hmMBu5EQ6WggkziU+jB8TMjK4B si9LhiEZouXGImG2Mj6204lWyO5Y51a4viq3zF7qTJsygp1MQilXao8Tw/pBYwkztR uEa1q35Sj8mYn62ehpmykPqySgdWadSMnIQlrzeuGx99n339bMH82+/L1zcMqLwKqA J6T0fpebAdUTg== Date: Wed, 7 Nov 2012 22:17:30 +0100 From: Alexander Leidinger To: Eitan Adler Subject: Re: removing support for ICC?? Message-ID: <20121107221730.000017c1@unknown> In-Reply-To: References: X-Mailer: Claws Mail 3.8.0cvs30 (GTK+ 2.24.10; i586-pc-mingw32msvc) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: E611984479F.A049C X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.455, required 6, autolearn=disabled, ALL_TRUSTED -1.00, AWL -0.56, DKIM_SIGNED 0.10, T_DKIM_INVALID 0.01, T_RP_MATCHES_RCVD -0.01) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1352927854.12768@w3zXcC3xsFLaqEYTlZc0bw X-EBL-Spam-Status: No Cc: bde@freebsd.org, freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Nov 2012 21:17:44 -0000 On Tue, 6 Nov 2012 15:58:45 -0500 Eitan Adler wrote: > Is there any reason to continue to keep the legacy __INTEL_COMPILER > conditional includes around? Is there a reason to remove them from cdefs.h? There aren't a lot of them, they don't obfuscate things, they are not in the way of improving things, they don't make the existing stuff harder to read. > Anyone have any objection against? The last time this came up I was OK to remove them from everywhere except for cdefs.h. If you want to remove them, please provide good reasons why to remove them (see also below). > I tested this and I found that only the following differed: > > -MD5 (/usr/obj/home/eitan/patchen/freebsd-head/sys/GENERIC/vers.o) = > fb34ba12ae401a00dcdccf3614b6e1a5 > +MD5 (/usr/obj/home/eitan/patchen/freebsd-head/sys/GENERIC/vers.o) = > 4cead614a48701968fcc0e1e00b1538c > -MD5 > (/usr/obj/home/eitan/patchen/freebsd-head/sys/GENERIC/hpt27xx_config.o) > = 3fc71ae3e198661796846eb68c3ef1b0 +MD5 > (/usr/obj/home/eitan/patchen/freebsd-head/sys/GENERIC/hpt27xx_config.o) > = e3b9f53df5c6d14e4be03ff750638bc5 cdefs.h is not only used in the kernel, but also in the userland. Anything from userland which includes cdefs.h and may also compile on other operating systems benefits from keeping this support in cdefs.h. > diff --git a/sys/sys/cdefs.h b/sys/sys/cdefs.h > index ad6aefc..a19cd46 100644 > --- a/sys/sys/cdefs.h > +++ b/sys/sys/cdefs.h > @@ -312,12 +295,12 @@ > #define __returns_twice > #endif > > -/* XXX: should use `#if __STDC_VERSION__ < 199901'. */ > +/* XXX: should use if __STDC_VERSION__ < 199901'. */ > #if !__GNUC_PREREQ__(2, 7) && !defined(__INTEL_COMPILER) > #define __func__ NULL > #endif This is an unrelated change. Bye, Alexander. -- http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137