From owner-cvs-all Wed May 23 16: 6: 0 2001 Delivered-To: cvs-all@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id CC73A37B642; Wed, 23 May 2001 16:05:50 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.2/8.11.2) with ESMTP id f4NN5ZG90582; Wed, 23 May 2001 16:05:35 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010523171709.R17514@superconductor.rush.net> Date: Wed, 23 May 2001 16:05:41 -0700 (PDT) From: John Baldwin To: Alfred Perlstein Subject: Re: cvs commit: src/sys/kern kern_synch.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 23-May-01 Alfred Perlstein wrote: > * John Baldwin [010523 15:39] wrote: >> jhb 2001/05/23 12:38:27 PDT >> >> Modified files: >> sys/kern kern_synch.c >> Log: >> Add in assertions to ensure that we always call msleep or mawait with >> either a timeout or a held mutex to detect unprotected infinite sleeps >> that can easily lead to deadlock. >> >> Submitted by: alfred > > I'm glad to see this assertion go in, however it's really not perfect, > it will not detect tsleeps with a timeout without a mutex held because > that is "valid". I really think we need some sort of way to really > "pause" rather than wait for a signalling. Anyhow, we'll get to it > one day. :) Agreed. cv's require a mutex, so as things move to cv's this will become less of a problem. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message