From owner-svn-src-all@FreeBSD.ORG Sat Jun 5 08:00:53 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 42F04106564A; Sat, 5 Jun 2010 08:00:53 +0000 (UTC) (envelope-from trasz@FreeBSD.org) Received: from svn.freebsd.org (unknown [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 328718FC0C; Sat, 5 Jun 2010 08:00:53 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id o5580rsP058018; Sat, 5 Jun 2010 08:00:53 GMT (envelope-from trasz@svn.freebsd.org) Received: (from trasz@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id o5580rr7058016; Sat, 5 Jun 2010 08:00:53 GMT (envelope-from trasz@svn.freebsd.org) Message-Id: <201006050800.o5580rr7058016@svn.freebsd.org> From: Edward Tomasz Napierala Date: Sat, 5 Jun 2010 08:00:53 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r208812 - head/sys/geom/mountver X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2010 08:00:53 -0000 Author: trasz Date: Sat Jun 5 08:00:52 2010 New Revision: 208812 URL: http://svn.freebsd.org/changeset/base/208812 Log: Make sure not to pass NULL to g_orphan_provider(). Found with: Coverity Prevent CID: 3411 Modified: head/sys/geom/mountver/g_mountver.c Modified: head/sys/geom/mountver/g_mountver.c ============================================================================== --- head/sys/geom/mountver/g_mountver.c Sat Jun 5 07:40:32 2010 (r208811) +++ head/sys/geom/mountver/g_mountver.c Sat Jun 5 08:00:52 2010 (r208812) @@ -343,7 +343,8 @@ g_mountver_destroy(struct g_geom *gp, bo } else { G_MOUNTVER_DEBUG(0, "Device %s removed.", gp->name); } - g_orphan_provider(pp, ENXIO); + if (pp != NULL) + g_orphan_provider(pp, ENXIO); g_mountver_discard_queued(gp); g_free(sc->sc_provider_name); g_free(gp->softc);