From owner-svn-ports-head@freebsd.org Wed Sep 28 14:31:32 2016 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 36821C01674; Wed, 28 Sep 2016 14:31:32 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0E2E01847; Wed, 28 Sep 2016 14:31:31 +0000 (UTC) (envelope-from freebsd.contact@marino.st) Received: from [127.0.0.1] (ip70-178-28-115.ks.ks.cox.net [70.178.28.115]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id BD25343BDA; Wed, 28 Sep 2016 09:31:10 -0500 (CDT) Subject: Re: svn commit: r422874 - in head: devel/efl net-mgmt/nsca-ng net-mgmt/zabbix3-server net-mgmt/zabbix32-server www/tomcat-native To: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201609281347.u8SDls64072549@repo.freebsd.org> Reply-To: marino@freebsd.org From: John Marino Message-ID: <2930934c-272b-50bd-8c7f-d02a7761f92f@marino.st> Date: Wed, 28 Sep 2016 09:31:23 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <201609281347.u8SDls64072549@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Antivirus: avast! (VPS 160928-1, 09/28/2016), Outbound message X-Antivirus-Status: Clean X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2016 14:31:32 -0000 On 9/28/2016 08:47, Mathieu Arnold wrote: > Author: mat > Date: Wed Sep 28 13:47:53 2016 > New Revision: 422874 > URL: https://svnweb.freebsd.org/changeset/ports/422874 > > Log: > Also, you can't set SSL_DEFAULT, and don't give bad advices to people, > it should never be set directly, but always through DEFAULT_VERSIONS. > fair point about setting though DEFAULT_VERSIONS, but it appears to me this is purely a semantic policy. From looking at the code, there's no technical issue with setting SSL_DEFAULT instead. It's just doing it before bsd.default-versions.mk can do exactly the same thing. I'm fine with this "just use DEFAULT_VERSIONS+=" policy but I did want to be pedantic that the other way caused no problem. (and is actually more intuitive but that's neither here nor there) --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus