From owner-svn-src-head@freebsd.org Thu Jun 1 15:32:40 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6DC10AFF94E; Thu, 1 Jun 2017 15:32:40 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-yw0-x22b.google.com (mail-yw0-x22b.google.com [IPv6:2607:f8b0:4002:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2702C7EF12; Thu, 1 Jun 2017 15:32:40 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-yw0-x22b.google.com with SMTP id b68so21630774ywe.3; Thu, 01 Jun 2017 08:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=G1Dp3QLzQWCa4w/uvjLo8LkdmzAKan+et9zn+iUbRLc=; b=QpZLDcKgyWUgQDfuDTd2d3FLrPRrXgHw1F51Po8nnkQOSn61pNhsN4iBlK01ExKfyU glRvyvR3Fe0AOKZuRDrFOZHQDsT7iaPvI8rORdieSgvnV0fIN7HFArcrz8NITZbmPe3H v8Ew50y9TrJ/zr+Doyv2T5gUa/j25ZsNo5PJ+yINPB+QPOsau8EVuoYL6JSsgxCefFzw oS0o0egsrGrEaDQ6nU0jweRWk+oWiTdR+1RTBRFuaZxoR+9LyKQCYROhX1bwzN62Ux77 VB9l6nFlb8uL//eID4ixIIYyEhAd0guCb1K2oRu5GxKaSYf05VDQNKqD2rNET3oehsiQ idVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=G1Dp3QLzQWCa4w/uvjLo8LkdmzAKan+et9zn+iUbRLc=; b=nZaAXMIni6AU2cFW0JqDYmqtdKDCJeksjh75t9Tj+dPg+9Hgf+1FLxtidKS+SZTdcO QYMWVtaO1HSmUlDO6sfFcA4sSeagEWZHtaknRFBiGtO3+mC6EyVQbnK9UufzBMXiOqMx JZ8xPEknp0yGP1mT1hnO8b4z8L/mYfdb3tIH5rbLdO92vUiQdZq9uXg790GeH21tXU8i CplshH7YQcvMhgGkKyRlB5W0N5u32ZpT9XlQazXu5qTDdPgtn4t4jcAnKuwWlG2e/x9f g6uQgS680HOmtkLgR1MtS4XMoyxn6O2hOdxSgO1KAtgbgJF2h4XXzBbpfPOQmbtRS8bQ lPqA== X-Gm-Message-State: AODbwcAx5zhcdGxRHh36sECO3Nyvjt3yWF3O0x1/1He/Xn2OWZ8rVDb/ lwQw6ULtryQul8nw060OzbZSqFrZnA== X-Received: by 10.129.156.5 with SMTP id t5mr1876512ywg.257.1496331159235; Thu, 01 Jun 2017 08:32:39 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.13.206.199 with HTTP; Thu, 1 Jun 2017 08:32:38 -0700 (PDT) In-Reply-To: <78A8D734-A627-437D-AE63-BA94C543C36B@xcllnt.net> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> <78A8D734-A627-437D-AE63-BA94C543C36B@xcllnt.net> From: Alan Somers Date: Thu, 1 Jun 2017 09:32:38 -0600 X-Google-Sender-Auth: FpqHpPjDSXq7Jz6EUXQSwn20Ax8 Message-ID: Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests To: Marcel Moolenaar Cc: "Ngie Cooper (yaneurabeya)" , Brooks Davis , Ngie Cooper , Marcel Moolenaar , "Simon J. Gerraty" , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jun 2017 15:32:40 -0000 On Thu, Jun 1, 2017 at 9:11 AM, Marcel Moolenaar wrote: > > On May 31, 2017, at 11:06 PM, Ngie Cooper (yaneurabeya) > wrote: > > > On May 31, 2017, at 10:03 PM, Brooks Davis wrote: > > On Wed, May 31, 2017 at 08:01:12AM +0000, Ngie Cooper wrote: > > Author: ngie > Date: Wed May 31 08:01:12 2017 > New Revision: 319295 > URL: https://svnweb.freebsd.org/changeset/base/319295 > > Log: > Update the usr.bin/mkimg golden test output files after ^/head@r319125 > > ^/head@r319125 changed the location of the backup pmbr, requiring the > output files to be regenerated, since they're binary disk dumps. > > The output files were regenerated with "make rebase"--fixed in > ^/head@r319294. > > > These should not be stored uuencoded. It serves no purpose other > than bloating the repo and causing spammy commit mails like this one > where we got a huge tail of garbage output. > > > Hi Brooks, > I=E2=80=99m not entirely sure why the files were uuencoded to be honest. = I think > that=E2=80=99s a good question for Marcel and some of the folks at Junipe= r, since > they wrote the tool/tests. > > > Result files used to start off as binary files. uuencoding is a given in > that case. I eventually switched to using hexdump -C, because that makes= it > easier to analyze and understand differences. The uuencoding was kept to > remain independent of version control system, file attributes and > end-of-line characteristics of the host machine: nothing more annoying th= at > checking out textual result files and have test failures because =E2=80= =98\n=E2=80=99 was > replaced by =E2=80=98\r\n=E2=80=99. > > Even if the files aren=E2=80=99t unencoded, there=E2=80=99s always someon= e who treats it as > spammy and a tail of garbage. It=E2=80=99s just a knee-jerk reaction to s= eeing > something that isn=E2=80=99t understood, I think. As such, there=E2=80=99= s no reason to > change =E2=80=94 in fact, changing would be bloating the repo. > > -- > Marcel Moolenaar > marcel@xcllnt.net If the files are binary, then why not store them as binary files? Subversion can handle that. That way the tests won't need to decode them, svn clients won't change their line endings, and commit mail won't include their diffs. -Alan