From owner-svn-src-all@freebsd.org Wed Mar 4 01:56:17 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1190A2616BF for ; Wed, 4 Mar 2020 01:56:17 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48XH6R5ZXcz3PYQ for ; Wed, 4 Mar 2020 01:56:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf34.google.com with SMTP id r15so116333qve.3 for ; Tue, 03 Mar 2020 17:56:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Hf6gsG4xjkVc4NP/m/dsrcvp0SifAiHYNnXcICVRTko=; b=EsyOVZYZ8GHlu07edYt47RnwSNftIANMy8kw5gITz87xkC3/haxOArf7OOUxTP0c1y lPuWGMCvwkfjJdR+AwxkEFD0rzwDbeKaiauvEKyHntCmKXyyaprZNqyFvkWgwgtu/joD CMmm43v202UtehJ1l33JYLENM6paKJjgQaY0t38AY1GOdgA2OnzTc/s2uuz2VgW9UydL WzOyKT/RzY9TcjkAYPn/z5SY5741weV6DiKHZhuJ2Bg1MEGz8d3AnDLnmRDBSgr4626X GVQt0OeChy6oCftwyWVVQzNLBXFf2GRERdnVt1WDHoCvys80soxSsGjIUCPduYdBqSvN asVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Hf6gsG4xjkVc4NP/m/dsrcvp0SifAiHYNnXcICVRTko=; b=I6C/MuPI08K990/MxIaSob3LKulb36pbRAqbt/C1Nb4+qjtkmnJY+17j1fmzq5B05p vqnRd4Fd8Yql8IWtbnEZ+O/KVN/bCgzM8lFuF/wSeJrBKH701qZMcXaQMB3f0tgU7e8A n8HyI5Eu/IEnOmbkUmZkeSPHXyyKlSLe1ikI2KsQl3umup3QB21Y0uxyGHhUEhfZBxvG 3TYDU9XHxUPavGEtR+0+hD4VyBQ94oOeqdcnNJ10kMzq1/Nrctb7I8L8NcHj+r0JkM/r XJXvIzIMaT8GzXpBsOSyejUKOsVd21rRalgbhPZVXv4/lqgn7IH7erkD1zA6PcLuK2vf 8ctg== X-Gm-Message-State: ANhLgQ1cj8NEklSDq7QwHnW4+yEsxXXTfwXnUJo3YET7aHBeLiLCuvMA PRLBNbKLm9a0rLgsrclgkzJitcprJDrCUhlHC46lSg== X-Google-Smtp-Source: ADFU+vvJZDTqE/1m7gj2Cofddfoiaf15eWAUB1rk9SFLAi/a+EH15jJcFQf5pNn0/HYkjR3Lie9Cg8k/z+eBCHcDEyk= X-Received: by 2002:ad4:4e88:: with SMTP id dy8mr343652qvb.118.1583286974349; Tue, 03 Mar 2020 17:56:14 -0800 (PST) MIME-Version: 1.0 References: <202003011727.021HRU5G076569@repo.freebsd.org> <81a089ea-d8a4-9f4b-dc24-3a7bd7e4cbba@FreeBSD.org> In-Reply-To: <81a089ea-d8a4-9f4b-dc24-3a7bd7e4cbba@FreeBSD.org> From: Warner Losh Date: Tue, 3 Mar 2020 18:56:03 -0700 Message-ID: Subject: Re: svn commit: r358486 - head/sys/dev/bce To: John Baldwin Cc: Warner Losh , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 48XH6R5ZXcz3PYQ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=EsyOVZYZ; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f34) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.91 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.996,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[4.3.f.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-1.91)[ip: (-6.00), ipnet: 2607:f8b0::/32(-1.86), asn: 15169(-1.66), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2020 01:56:17 -0000 On Mon, Mar 2, 2020 at 3:06 PM John Baldwin wrote: > On 3/1/20 9:27 AM, Warner Losh wrote: > > Author: imp > > Date: Sun Mar 1 17:27:30 2020 > > New Revision: 358486 > > URL: https://svnweb.freebsd.org/changeset/base/358486 > > > > Log: > > Remove all the compatibility hacks for systems that predate FreeBSD 8. > Some of > > these look to be cut and pasted from other drivers since this driver > was > > committed to FreeBSD 7-current and MFC'd to FreeBSD 6. The ones for > FreeBSD 4 > > and 5 likely never were working... > > You'd be surprised. I had to backport this to 4.x for Y!BSD, so I do > suspect > the 4.x bits worked fine. Good to clean out the cruft regardless. > The more you know... the more you think a good stiff drink is in order :) Warner