From owner-svn-src-all@FreeBSD.ORG Sun Jun 26 13:19:55 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8137B106566B; Sun, 26 Jun 2011 13:19:55 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 42BF58FC1C; Sun, 26 Jun 2011 13:19:55 +0000 (UTC) Received: from [127.0.0.1] (pooker.samsco.org [168.103.85.57]) (authenticated bits=0) by pooker.samsco.org (8.14.4/8.14.4) with ESMTP id p5QCpYnF022502; Sun, 26 Jun 2011 06:51:34 -0600 (MDT) (envelope-from scottl@samsco.org) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Scott Long In-Reply-To: <201106260132.p5Q1Wlrw030787@svn.freebsd.org> Date: Sun, 26 Jun 2011 06:51:34 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <537C5DE9-9B16-4A4F-AE94-25C9DA7D3B78@samsco.org> References: <201106260132.p5Q1Wlrw030787@svn.freebsd.org> To: "Justin T. Gibbs" X-Mailer: Apple Mail (2.1084) X-Spam-Status: No, score=-50.0 required=3.8 tests=ALL_TRUSTED, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.0 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on pooker.samsco.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r223557 - head/sys/cam/scsi X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2011 13:19:55 -0000 On Jun 25, 2011, at 7:32 PM, Justin T. Gibbs wrote: > Author: gibbs > Date: Sun Jun 26 01:32:46 2011 > New Revision: 223557 > URL: http://svn.freebsd.org/changeset/base/223557 >=20 > Log: > cam/scsi/scsi_cd.c: > In cdregister(), hold the periph lock semaphore during changer > probe/configuration. This removes a window where an open of the > cd device may succeed before probe processing has completed. >=20 I hope this works for Andre (and likely others). Regardless though, = cdregister() and daregister() need to be refactored to not require this = delicate mess of locking hacks. Scott