From owner-freebsd-ports@FreeBSD.ORG Sun Jul 1 21:47:06 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 76E87106566C for ; Sun, 1 Jul 2012 21:47:06 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id D366C8FC14 for ; Sun, 1 Jul 2012 21:47:05 +0000 (UTC) Received: by lbon10 with SMTP id n10so8421205lbo.13 for ; Sun, 01 Jul 2012 14:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=bBBV8Sg3DBFUJvkjWotW5YMKTYuDSOLDooTb38bvbao=; b=Kqgo7F6/NXqs1/VF0ZzQj19f1pWOv2P4pCpbxeLDnquAuf5/Bxy6aCeWmO00I4mHA7 EEX4lloO70wKFvQ7RLSJ9v7bXm38R47lZ1DF1yY7vaE6NSP+MZpCtZdat6DL3FSPtTV7 KA61LqJGfOfYCRWbUKbRDPZ1pHpBq/2YaHSCl36oHT7OphcxQkwzM9S01d4fF4pEprPI 1r1xo/NG9hqSoD0S9dewjHgki/kXWbbHgV15d1oseHFUln19/iZPb6qgNtBd7mh7UqOx 5MlyKDf1KqYXlTC6dVhEG0hK4MZF5hGYzQxg72FgCvU5gutUtfmVNPCqjiitNLG9XBDL 4Sbg== MIME-Version: 1.0 Received: by 10.152.108.144 with SMTP id hk16mr10433062lab.2.1341179224704; Sun, 01 Jul 2012 14:47:04 -0700 (PDT) Received: by 10.152.24.131 with HTTP; Sun, 1 Jul 2012 14:47:04 -0700 (PDT) Received: by 10.152.24.131 with HTTP; Sun, 1 Jul 2012 14:47:04 -0700 (PDT) In-Reply-To: <1341168064.10742.2.camel@Nokia-N900-42-11> References: <1341164678.10569.2.camel@Nokia-N900-42-11> <1341168064.10742.2.camel@Nokia-N900-42-11> Date: Sun, 1 Jul 2012 23:47:04 +0200 Message-ID: From: =?ISO-8859-1?Q?Fernando_Apestegu=EDa?= To: =?ISO-8859-1?Q?Bernhard_Fr=F6hlich?= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: freebsd-ports@freebsd.org Subject: Re: [new-port] JDownloader X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jul 2012 21:47:06 -0000 El 01/07/2012 20:45, "Bernhard Fr=F6hlich" escribi=F3: > > On So., 1. Jul. 2012 20:09:09 CEST, Fernando Apestegu=EDa < fernando.apesteguia@gmail.com> wrote: > > > On Sun, Jul 1, 2012 at 7:44 PM, Bernhard Fr=F6hlich > > wrote: > > > On So., 1. Jul. 2012 19:32:58 CEST, Fernando Apestegu=EDa > > > wrote: > > > > > > > Hi all, > > > > > > > > I have a preliminary version of a port for JDownloader[1] since it > > > > seems to be a wanted port[2] > > > > > > > > Here is the Makefile: > > > > > > > > ----------------------------------------------------------------------- > > > > # New ports collection makefile for: jdownloader > > > > # Date created: Sun Jul 1 2012 > > > > # Whom: Fernando Apesteguia > > > > # > > > > # $FreeBSD$ > > > > > > > > PORTNAME=3D jdownloader > > > > PORTVERSION=3D 1.0 > > > > CATEGORIES=3D java ftp > > > > MASTER_SITES=3D http://212.117.163.148/ > > > > DISTNAME=3D jd.sh > > > > EXTRACT_SUFX=3D > > > > > > > > MAINTAINER=3D fernando.apesteguia@gmail.com > > > > COMMENT=3D Download management for one-click-hosters > > > > > > > > RUN_DEPENDS=3D ${LOCALBASE}/bin/java:${PORTSDIR}/java/diablo-jdk16 > > > > RUN_DEPENDS+=3D ${LOCALBASE}/bin/wget:${PORTSDIR}/ftp/wget > > > > > > > > USE_JAVA=3D yes > > > > JAVA_VERSION=3D 1.6+ > > > > NO_BUILD=3D yes > > > > > > > > WRKSRC=3D ${WRKDIR} > > > > > > > > do-extract: > > > > @${MKDIR} ${WRKDIR} > > > > @${CP} ${DISTDIR}/jd.sh ${WRKSRC} > > > > > > > > do-install: > > > > @${MKDIR} ${PREFIX}/${PORTNAME} > > > > @${INSTALL_SCRIPT} ${WRKSRC}/jd.sh ${PREFIX}/bin > > > > > > > > post-install: > > > > @${ECHO_MSG} "" > > > > @${ECHO_MSG} > > > > "*************************************************************************" > > > > @${ECHO_MSG} JDownloader will update itself to the latest version > > > > when it runs for the @${ECHO_MSG} first time. Please run > > > > ${LOCALBASE}/bin/jd.sh @${ECHO_MSG} to complete the installation > > > > @${ECHO_MSG} > > > > "*************************************************************************" > > > > @${ECHO_MSG} "" @${CAT} ${PKGMESSAGE} > > > > > > > > .include > > > > ----------------------------------------------------------------------- > > > > > > > > The port just needs a simple patch file (patch-jd.sh): > > > > > > > > ----------------------------------------------------------------------- > > > > --- jd.sh.orig 2012-07-01 14:23:07.000000000 +0200 > > > > +++ jd.sh 2012-07-01 14:24:15.000000000 +0200 > > > > @@ -1,4 +1,4 @@ > > > > -#!/bin/bash > > > > +#!/bin/sh > > > > #JD Installer/Starter Version 0.2 > > > > #by Jiaz(JD-Team), jiaz@jdownloader.org > > > > #You need at least: > > > > ----------------------------------------------------------------------- > > > > > > > > The jd.sh runs fine with sh(1) so there is no need for a new run > > > > dependency for bash(1). > > > > > > > > The port installs one single file (jd.sh). This script when executed, > > > > checks for the presence of the JDownloader jar files under the ~/.j= d > > > > directory. If they don't exist it starts the uploader application and > > > > downloads the latest files. If the files were already present, it > > > > launches the installation and if the installation is already present, > > > > it launches the program. > > > > Uninstalling the port uninstalls the jd.sh file but _not_ the actua= l > > > > application that might be installed by the users in their respectiv= e > > > > home directories. Taking into account that JDownloader can be > > > > installed anyway just by downloading the source I don't suppose thi= s > > > > is a concern. Since the program can act as a server (it installs a > > > > plugin for remote controlling the application similarly to what > > > > transmission torrent does), it shows a message after the > > > > installation. > > > > > > > > I haven't submitted a PR yet, so any suggestions are welcomed. > > > > > > > > Thanks in advance. > > > > > > > > [1] http://jdownloader.org/ > > > > [2] http://wiki.freebsd.org/WantedPorts > > > > > > Is there a reason why you explicitly add diablo-jdk16 as runtime > > > dependency? The use_java stuff should be sufficient. > > > > You're right, doesn't seem to be necessary. > > > > > > > > Why have you decided to download and install the jar files on first > > > run of the shellscript? That doesn't sound like a good idea to me > > > because it breaks proper updates, deinstall and creates useless binar= y > > > packages. > > > > I haven't. jd.sh is provided by the upstream project. The alternative > > is another "nicer" installation program. > > FreeBSD portstree is exactly that nicer installer that you are talking about. > > > Since this is just a wrapper to do several things and the actual > > software is installed in the user's home directory, I agree we could > > have two different users with two different versions of JDownloader. > > By the way, the jd.sh script tries to update _just the first time_ but > > after that, the user can always look for new versions from inside > > JDownloader (in fact, it checks for new versions from the java code > > every time it runs). > > Yeah many projects implement their own update mechanism mostly because windows has no package management. For a FreeBSD user and administrator it should be an seamless integration so that he doesn't need to search for update dialogs or buttons within installed programms. Even fully automated updating is a problem in case of regressions and for major changes in functionality. > > So what we need is a port that properly installs the few jar files into system paths and a shellscript that launches a jvm with that jar files. Additionally we should disable the automatic updating stuff. Have a look at other java based ports on how to do that. > > > I checked the Fedora 16(?) package for JDownloader and does pretty > > much the same thing. > > Yeah, bad habits are spreading easily.