From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jul 1 02:20:02 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 796DC1065675 for ; Wed, 1 Jul 2009 02:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 54EBE8FC22 for ; Wed, 1 Jul 2009 02:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n612K2UK002151 for ; Wed, 1 Jul 2009 02:20:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n612K28L002150; Wed, 1 Jul 2009 02:20:02 GMT (envelope-from gnats) Resent-Date: Wed, 1 Jul 2009 02:20:02 GMT Resent-Message-Id: <200907010220.n612K28L002150@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Nathan Whitehorn Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 45548106564A for ; Wed, 1 Jul 2009 02:14:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 343DF8FC1C for ; Wed, 1 Jul 2009 02:14:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n612E2N0079447 for ; Wed, 1 Jul 2009 02:14:02 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n612E2PQ079446; Wed, 1 Jul 2009 02:14:02 GMT (envelope-from nobody) Message-Id: <200907010214.n612E2PQ079446@www.freebsd.org> Date: Wed, 1 Jul 2009 02:14:02 GMT From: Nathan Whitehorn To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/136206: [patch] OVERRIDE_LINUX_NONBASE_PORTS not honored X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Jul 2009 02:20:02 -0000 >Number: 136206 >Category: ports >Synopsis: [patch] OVERRIDE_LINUX_NONBASE_PORTS not honored >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jul 01 02:20:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Nathan Whitehorn >Release: 8.0-CURRENT >Organization: University of Wisconsin >Environment: FreeBSD comporellon.tachypleus.net 8.0-CURRENT FreeBSD 8.0-CURRENT #20 r194939M: Thu Jun 25 01:54:40 CDT 2009 root@comporellon.tachypleus.net:/usr/obj/usr/src/sys/COMPORELLON amd64 >Description: After the change to Fedora 10 as the default Linux base on -CURRENT, you get messages like this even if OVERRIDE_LINUX_NONBASE_PORTS is set to f8: ** Port marked as IGNORE: x11/linux-f8-xorg-libs: bsd.linux-rpm.mk test failed: default package building at OSVERSION>=800076 was changed to linux-f10 ports, please define OVERRIDE_LINUX_NONBASE_PORTS to build other linux infrastructure ports >How-To-Repeat: >Fix: This is due to over-enthusiastic application of curly braces in the test on line 70 of bsd.linux-rpm.mk. Instead of testing defined(${OVERRIDE_LINUX_NONBASE_PORTS}), it should test defined(OVERRIDE_LINUX_NONBASE_PORTS). Patch attached with submission follows: --- bsd.linux-rpm.mk.dist 2009-06-30 21:09:06.000000000 -0500 +++ bsd.linux-rpm.mk 2009-06-30 21:09:19.000000000 -0500 @@ -67,7 +67,7 @@ LINUX_DIST_VER?= 4 . else LINUX_DIST_VER?= 10 -. if !defined(${OVERRIDE_LINUX_NONBASE_PORTS}) && \ +. if !defined(OVERRIDE_LINUX_NONBASE_PORTS) && \ ${LINUX_DIST_VER} != 10 IGNORE= bsd.linux-rpm.mk test failed: default package building at OSVERSION>=800076 was changed to linux-f10 ports, please define OVERRIDE_LINUX_NONBASE_PORTS to build other linux infrastructure ports . endif >Release-Note: >Audit-Trail: >Unformatted: