From owner-freebsd-current@FreeBSD.ORG Fri Dec 7 17:11:03 2007 Return-Path: Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C2FD16A418 for ; Fri, 7 Dec 2007 17:11:03 +0000 (UTC) (envelope-from tsw5@duke.edu) Received: from smtp.duke.edu (smtp-04.oit.duke.edu [152.3.174.85]) by mx1.freebsd.org (Postfix) with ESMTP id 4D53C13C448 for ; Fri, 7 Dec 2007 17:11:03 +0000 (UTC) (envelope-from tsw5@duke.edu) Received: from smtp.duke.edu (localhost.localdomain [127.0.0.1]) by localhost (Postfix) with SMTP id A4E8735A641; Fri, 7 Dec 2007 12:11:02 -0500 (EST) Received: from avenue.wintermute (cpe-076-182-024-090.nc.res.rr.com [76.182.24.90]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by smtp.duke.edu (Postfix) with ESMTP id 4F8FA35900A; Fri, 7 Dec 2007 12:11:02 -0500 (EST) Message-Id: <4A85ADA7-1528-4164-8566-506DEFFE5EB0@duke.edu> From: Todd Wasson To: =?ISO-8859-1?Q?S=F8ren_Schmidt?= In-Reply-To: <4759259A.3070000@deepcore.dk> Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Apple Message framework v915) Date: Fri, 7 Dec 2007 12:11:01 -0500 References: <1B3A2410-9C2A-4126-AC92-8E38B4A0D79A@duke.edu> <200712061726.lB6HQCIu023253@fire.js.berklix.net> <4758FC14.2080606@yandex.ru> <4759259A.3070000@deepcore.dk> X-Mailer: Apple Mail (2.915) X-PMX-Version: 5.4.0.320885, Antispam-Engine: 2.5.2.313940, Antispam-Data: 2007.12.7.85625 X-PerlMx-Spam: Gauge=XXII, Probability=22%, Report='RELAY_IN_PBL_11 2.5, RDNS_GENERIC_POOLED 0, RDNS_POOLED 0, RDNS_RESIDENTIAL 0, RDNS_SUSP 0, RDNS_SUSP_GENERIC 0, RDNS_SUSP_SPECIFIC 0, RELAY_IN_PBL 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __RDNS_POOLED_2 0, __SANE_MSGID 0' Cc: "Julian H. Stacey" , "Andrey V. Elsukov" , freebsd-current@FreeBSD.ORG, =?ISO-8859-1?Q?S=F8ren_Schmidt?= Subject: Re: BETA4 installer doesn't attach my HDD controller; BETA3 did X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2007 17:11:03 -0000 Julian, Andrey, and Soren, thank all of you for your help. I applied =20= Soren's patch (as I just pulled it from the tree via csup) and the =20 problem appears to be resolved. I appreciate your assistance and the =20= fast turnaround time on this. Todd On Dec 7, 2007, at 5:51 AM, S=F8ren Schmidt wrote: > Andrey V. Elsukov wrote: >> Todd Wasson wrote: >>>> Todd Wasson wrote: >>>>> I've got a Maxtor 6Y080L0 YAR41VW0 drive on a JMicron JMB368 =20 >>>>> UDMA133 >>>>> controller, and in the BETA4 installer the controller doesn't =20 >>>>> seem to >>>>> be properly attaching, which leads to the drive not being =20 >>>>> found. The >>>>> relevant sections from dmesg (as I'm not sure where else to look =20= >>>>> while >>>>> running the installer CD) are: >>>> >>>> Did you try "Safe Boot" key 3. >> >> I think this changes may create a regression: >> >> 1. the BETA3's version: >> >> ctlr->r_type2 =3D SYS_RES_MEMORY; >> ctlr->r_rid2 =3D PCIR_BAR(5); >> if ((ctlr->r_res2 =3D bus_alloc_resource_any(dev, = ctlr->r_type2, >> &ctlr->r_rid2, RF_ACTIVE))){ >> if ((error =3D ata_ahci_chipinit(dev))) >> return error; >> } >> We have two checks here. Probably your controller doesn't allocate a >> memory resource for the AHCI, but it works because it skips second >> checks. >> >> 2. the BETA4's version: >> >> if ((error =3D ata_ahci_chipinit(dev))) >> return error; >> >> In this version driver doesn't pass it. I've already sent patch >> for test to your PR, but i attach it again. >> May be Soren can comment it? > Yeah, there's a bug allright, attached patch is the right way to fix =20= > it, I'll commit when I get a few.. > > -S=F8ren > > > ? JMicrom-p1 > ? ich-sata-fix > Index: ata-chipset.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/ncvs/src/sys/dev/ata/ata-chipset.c,v > retrieving revision 1.209 > diff -u -r1.209 ata-chipset.c > --- ata-chipset.c 26 Nov 2007 19:08:08 -0000 1.209 > +++ ata-chipset.c 7 Dec 2007 10:49:06 -0000 > @@ -2260,7 +2309,7 @@ > pci_write_config(dev, 0x40, 0x80c0a131, 4); > pci_write_config(dev, 0x80, 0x01200000, 4); > > - if ((error =3D ata_ahci_chipinit(dev))) > + if (ctlr->chip->cfg1 && (error =3D ata_ahci_chipinit(dev))) > return error; > > ctlr->allocate =3D ata_jmicron_allocate;