Date: Sat, 22 Oct 2022 21:09:58 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 267183] [NEW PORT] games/starfetch: Command line tool that displays constellations Message-ID: <bug-267183-7788-8qbDXnJF5A@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-267183-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-267183-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D267183 --- Comment #2 from Jes=C3=BAs Daniel Colmenares Oviedo <DtxdF@disroot.org>= --- (In reply to Nuno Teixeira from comment #1) Hi! > REINPLACE_CMD ran, but did not modify file contents: src/starfetch.cpp This warning is because by default, the value of that variable is /usr/local/share/starfetch/. Therefore, when sed_checked.sh modifies the contents of src/starfetch.cpp, it warns because there is no change. But this warning should disappear when DATADIR is a different path: With the same DATADIR: # make patch $ cat work/reinplace_warnings.txt - - REINPLACE_CMD ran, but did not modify file contents: src/starfetch.cpp $ rg --pcre2 '^string path' work/starfetch-0.0.2/src/starfetch.cpp 26:string path =3D "/usr/local/share/starfetch/"; With a different DATADIR: # make DATADIR=3D/tmp/starfetch patch $ test -f 'work/reinplace_warnings.txt'; echo $? 1 $ rg --pcre2 '^string path' work/starfetch-0.0.2/src/starfetch.cpp 26:string path =3D "/tmp/starfetch/"; --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-267183-7788-8qbDXnJF5A>