From owner-p4-projects@FreeBSD.ORG  Wed Aug 13 13:56:15 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4A204106568C; Wed, 13 Aug 2008 13:56:15 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0E5F9106567F
	for <perforce@FreeBSD.org>; Wed, 13 Aug 2008 13:56:15 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 06EFE8FC08
	for <perforce@FreeBSD.org>; Wed, 13 Aug 2008 13:56:15 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m7DDuE86047890
	for <perforce@FreeBSD.org>; Wed, 13 Aug 2008 13:56:14 GMT
	(envelope-from ed@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m7DDuEm1047888
	for perforce@freebsd.org; Wed, 13 Aug 2008 13:56:14 GMT
	(envelope-from ed@FreeBSD.org)
Date: Wed, 13 Aug 2008 13:56:14 GMT
Message-Id: <200808131356.m7DDuEm1047888@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	ed@FreeBSD.org using -f
From: Ed Schouten <ed@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 147297 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Aug 2008 13:56:15 -0000

http://perforce.freebsd.org/chv.cgi?CH=147297

Change 147297 by ed@ed_mekker on 2008/08/13 13:55:42

	Remove this debugging warning I added to the pts(4) driver to
	spot misbehaving applications. We should eventually get rid of
	/dev/ptmx somewhere in FreeBSD 42.0, but because Linux binaries
	tend to use it and many badly written applications use it (KDE's
	Konsole being one), I'll remove the warning.

Affected files ...

.. //depot/projects/mpsafetty/sys/kern/tty_pts.c#7 edit

Differences ...

==== //depot/projects/mpsafetty/sys/kern/tty_pts.c#7 (text+ko) ====

@@ -607,8 +607,6 @@
 }
 
 #if defined(PTS_COMPAT) || defined(PTS_LINUX)
-static int pts_warningcnt = 10;
-
 static int
 ptmx_fdopen(struct cdev *dev, int fflags, struct thread *td, struct file *fp)
 {
@@ -618,14 +616,6 @@
 	if (error != 0)
 		return (error);
 
-	/* Raise a warning when a legacy PTY has been allocated */
-	if (pts_warningcnt > 0) {
-		pts_warningcnt--;
-		printf("pid %d (%s) is using legacy pts allocation%s\n", 
-		    td->td_proc->p_pid, td->td_name,
-		    pts_warningcnt ? "" : " - not logging anymore");
-	}
-
 	return (0);
 }