From owner-svn-src-all@freebsd.org Wed Jan 10 17:55:54 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C0163E6B4B1; Wed, 10 Jan 2018 17:55:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 98E3B81D9F; Wed, 10 Jan 2018 17:55:54 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (astound-66-234-199-215.ca.astound.net [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id E703910A7DB; Wed, 10 Jan 2018 12:55:45 -0500 (EST) From: John Baldwin To: Warner Losh Cc: Alexey Dokuchaev , "Rodney W. Grimes" , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Warner Losh Subject: Re: svn commit: r327767 - in head/sys: conf i386/bios i386/conf i386/isa Date: Wed, 10 Jan 2018 09:38:46 -0800 Message-ID: <5012765.tdQagMdlRk@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: References: <201801101459.w0AExJWM055025@repo.freebsd.org> <20180110171444.GA85022@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Wed, 10 Jan 2018 12:55:46 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 17:55:54 -0000 On Wednesday, January 10, 2018 10:20:17 AM Warner Losh wrote: > On Wed, Jan 10, 2018 at 10:14 AM, Alexey Dokuchaev > wrote: > > > On Wed, Jan 10, 2018 at 10:01:41AM -0700, Warner Losh wrote: > > > On Wed, Jan 10, 2018 at 9:58 AM, Alexey Dokuchaev > > wrote: > > > > On Wed, Jan 10, 2018 at 09:48:05AM -0700, Warner Losh wrote: > > > > > On Wed, Jan 10, 2018 at 9:31 AM, Rodney W. Grimes wrote: > > > > > > > New Revision: 327767 > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/327767 > > > > > > > > > > > > > > Log: > > > > > > > Retire pmtimer driver. Move time fixing into apm driver. Move > > > > > > > Iwasaki-san's copyright over. Remove FIXME code that couldn't > > > > possibly > > > > > > > work. Call tc_settime() with our estimate of the delta we've > > been > > > > > > > alseep (the one we print) to adjust the time. Not sure what to > > do > > > > > > > about callouts, so keep the small #ifdef in place there. > > > > > > > > > > > > > > Differential Revision: https://reviews.freebsd.org/D13823 > > > > > > > > > > > > RELNOTES: ? > > > > > > Reason I ask is this effects custom kernel config file(s) > > > > > > > > > > Don't know. We don't normally document every kernel config file > > changes > > > > > that's required. > > > > > > > > Well, `pmtimer' is a bit special. It is required in the kernel config > > in > > > > order to preserve time counting during suspend (not sure about amd64, > > but > > > > at least on i386, "device pmtimer" is required to be in kernel config > > for > > > > timekeeping while sleeping). > > > > > > It's only required for APM. ACPI it's a nop. > > > > > > And it didn't (until I believe that I fixed it) even adjust the time for > > > APM. On APM it just prints how long the sleep was. > > > > Not sure of now, but at least back in 2013 pmtimer was required on my i386 > > ACPI-ish laptop (it is still required now, but I just don't run -CURRENT): > > > > https://lists.freebsd.org/pipermail/svn-src-all/2013-May/069020.html > > > It's been a nop in ACPI only on -current. Prior to making it a nop on > current ACPI set the time, it was a nop for amd64. Then it probably does warrant a relnotes entry if the effect going from 11 to 12 is that pmtimer has become non-optional / standard, so the kernel config option is obsolete. -- John Baldwin