Date: Sun, 17 May 1998 21:22:52 -0700 (PDT) From: Julian Elischer <julian@whistle.com> To: Terry Lambert <tlambert@primenet.com> Cc: current@FreeBSD.ORG Subject: Re: Patch to disable async, noatime for soft updates Message-ID: <Pine.BSF.3.95.980517211549.18213C-100000@current1.whistle.com> In-Reply-To: <199805180405.VAA26835@usr07.primenet.com>
next in thread | previous in thread | raw e-mail | index | archive | help
well as part of the Whistle crew looking over kirk's shoulder
during our sessions.. we obviously decided that this was your task :-)
On Mon, 18 May 1998, Terry Lambert wrote:
> Here is a patch to do what the subject says.
>
> I can't believe no one has bothered to do this yet.
>
> -------------------------------------------------------------------------------
> Index: ffs_vfsops.c
> ===================================================================
> RCS file: /b/cvstree/ncvs/src/sys/ufs/ffs/ffs_vfsops.c,v
> retrieving revision 1.81
> diff -c -r1.81 ffs_vfsops.c
> *** 1.81 1998/05/06 05:29:40
> --- ffs_vfsops.c 1998/05/18 04:04:07
> ***************
> *** 629,634 ****
> --- 629,638 ----
> if (error = bread(devvp, SBLOCK, SBSIZE, cred, &bp))
> goto out;
> fs = (struct fs *)bp->b_data;
> + /* soft updates is incompatible with "async" and "noatime"*/
> + if (fs->fs_flags & FS_DOSOFTDEP) {
> + mp->mnt_flag &= ~(MNT_ASYNC | MNT_NOATIME);
> + }
> if (fs->fs_magic != FS_MAGIC || fs->fs_bsize > MAXBSIZE ||
> fs->fs_bsize < sizeof(struct fs)) {
> error = EINVAL; /* XXX needs translation */
> -------------------------------------------------------------------------------
I'm not convinced this is correct but it can't be too far off.
What if softupdates is not enabled in that kernel?
I think it should be done in ffs_softdep.c in softdep_mount().
this is what sets the softdep flag and it should unset the others.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.95.980517211549.18213C-100000>